maria-developers team mailing list archive

Thread
Date

Re: [Commits] Rev 3353: Performed re-factoring and re-structuring of the code for mwl#248: in file:///home/igor/maria/maria-5.5-mwl248-changes/

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Michael Widenius <monty@xxxxxxxxxxxx>
Date: Tue, 31 Jul 2012 12:27:51 +0300
Cc: commits@xxxxxxxxxxx
In-reply-to: <CAJJDKOsUiFTSUBW+SXYo307MehqbSi7rGLQLvQ5hhFE686Lq7w@mail.gmail.com>
Reply-to: monty@xxxxxxxxxxxx

Hi!

>>>>> "Davi" == Davi Arnaut <davi@xxxxxxxxxxx> writes:

Davi> On Mon, Jul 30, 2012 at 7:34 AM, Oleksandr Byelkin
Davi> <sanja@xxxxxxxxxxxxxxxx> wrote:
>> 27.07.2012 20:57, Davi Arnaut пишет:
>>> 
>>> Also, bzero is deprecated.
>> AFAIK bzero is macro in our sources.

Davi> It is a macro if not available. Which then becomes a problem because
Davi> the bzero interface is not well defined (first argument begin char
Davi> pointer versus void pointer). It should be pretty simple, let's not
Davi> use deprecated and broken interfaces.

Actually, in mariadb code (and original mysql code) we use bzero a lot
and it's a stable, well tested, well known and well defined function.

Better to always use the same code to reset memory than doing it many
different ways. In MySQL code bzero() has been the offical and
recommended way to reset memory.

Regards,
Monty