maria-developers team mailing list archive
-
maria-developers team
-
Mailing list archive
-
Message #06858
MDEV-4309: Review for 201402181003_sanja_copy_calls_patch.diff
Hi Sanja,
My input for 201402181003_sanja_copy_calls_patch.diff:
* memcpy_field_possible() should have a function comment mentioning that it
checks whether memcpy_field_value() can be used.
* field_conv_incompatible() should have a function comment mentioning that
it is a function that is used instead of field_conv() when we know in
advance that memcpy_field_possible(...)==false.
Ok to push after this is addressed.
BR
Sergei
--
Sergei Petrunia, Software Developer
MariaDB | Skype: sergefp | Blog: http://s.petrunia.net/blog