maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Sergey!

On Jun 18, Sergey Vojtovich wrote:
> On Thu, Jun 18, 2015 at 12:06:30PM +0200, Sergei Golubchik wrote:
> > On Jun 17, svoj@xxxxxxxxxxx wrote:
> > > revision-id: 2e08ec24623e0b3d3db02333e16658dcfaa0535c
> > > parent(s): b776f8d3a8afff55d5f8208da7bdfce9aa33eb39
> > > committer: Sergey Vojtovich
> > > branch nick: mariadb
> > > timestamp: 2015-06-17 13:09:22 +0400
> > > message:
> > > 
> > > MDEV-7956 - handler::rebind_psi() takes 0.07% in OLTP RO
> > > 
> > > Do not call handler::rebind_psi() and handler::unbind_psi() when performance
> > > schema is compiled out.
> 
> I can just surround these calls with ifdef-s if you like. This way we'll keep
> PFS code completely intact.

No-no, please don't. Let's not multiply ifdef-s in the code.
For what you want to achieve, your patch is ok.

Regards,
Sergei