← Back to team overview

maria-developers team mailing list archive

Re: 1ee6b0ff748: MDEV-11115 CHECK constraints are not shown in I_S.TABLE_CONSTRAINTS


Hi Sergei,

Both the changes for this bug and the changes for MDEV-10355 are in a stage
tree named bb-10.2-<bug number>.  However, when I look at the automated
testing on their respective branches, I see a few failures.  As far as I
can tell, none of the failures could have been caused by my changes  To
give meaning to these results, I need a baseline for comparison for each
branch.  The respective baselines would be from just before I cloned each
branch.  Since I don't have those, I don't have any baselines for
comparison, and so the test results are meaningless.  How would you suggest
I proceed?

I'm going to sleep right now.  I'll check email again when I wake up before
the weekly call.


Jacob B. Mathew
Senior Software Engineer
MariaDB Corporation
+1 408 655 8999  (mobile)
jacob.b.mathew    (Skype)

On Sun, Mar 19, 2017 at 3:42 AM, Sergei Golubchik <serg@xxxxxxxxxxx> wrote:

> Hi, jacob.mathew!
> On Mar 16, jacob.mathew@xxxxxxxxxxx wrote:
> > revision-id: 1ee6b0ff74858dccd779c7974858c6d084c1cde5
> (mariadb-10.2.3-246-g1ee6b0ff748)
> > parent(s): 9f33288dde950343c46e6c5d6a4f233de191f477
> > author: Jacob Mathew
> > committer: Jacob Mathew
> > timestamp: 2017-03-16 18:31:11 -0700
> > message:
> >
> > MDEV-11115 CHECK constraints are not shown in I_S.TABLE_CONSTRAINTS
> >
> > Fixed handling of column-level CHECK constraints in
> > Fixed a bug regarding virtual column definitions whose name is the field
> name.
> > Fixed column-level CHECK constraint syntax in the test case.
> Ah, good. I had a feeling there was something wrong with field-level
> constraints in your first patch.
> This looks great now. Did you push it into a stage tree already?
> Like bb-10.2-jacob or something? If not - please do.
> If you did and buildbot didn't show anything bad, please squash your
> three commits into one, rebase it on top of the current 10.2 and push.
> Thanks!
> Regards,
> Sergei
> Chief Architect MariaDB
> and security@xxxxxxxxxxx

Follow ups