← Back to team overview

maria-developers team mailing list archive

Re: bf32018be96: Added support for VISIBLE attribute for indexes in CREATE TABLE

 

Hi!

On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik <serg@xxxxxxxxxxx> wrote:
>
> Hi, Michael!
>
> On Apr 13, Michael Widenius wrote:
> > revision-id: bf32018be96 (mariadb-10.5.2-126-gbf32018be96)
> > parent(s): 62c2d0f3e1f
> > author: Michael Widenius <monty@xxxxxxxxxxx>
> > committer: Michael Widenius <monty@xxxxxxxxxxx>
> > timestamp: 2020-04-09 01:37:02 +0300
> > message:
> >
> > Added support for VISIBLE attribute for indexes in CREATE TABLE
> >
> > MDEV-22199 Add VISIBLE attribute for indexes in CREATE TABLE
> >
> > This was done to make it easier to read in dumps from MySQL 8.0
>
> This is not a "dump from MySQL 8.0". It is an SQL export file generated
> by MySQL Workbench. And MySQL Workbench has a configuration option
> whether to put this VISIBLE in the sql file or not.

It's a dump from MySQL 8.0 done by workbench. I don't know if the configuration
is default or not, but I don't see any reason to not support it as
others can make
easily the same mistake.

Regards,
Monty


Follow ups

References