← Back to team overview

maria-developers team mailing list archive

Re: Please assign PRs that modify debian/ contents for Otto to review



It was to correct some other broken things.

Can I see a change log of your corrections to understand what went wrong?

Totally agree that it was mostly process error and review that went wrong,
so yes. PR merged. Let's do that. Nice and automated.

Best wishes with the talk.

On Fri, Aug 14, 2020 at 4:50 AM Otto Kekäläinen <otto@xxxxxxxxxxxxxx> wrote:

> Hello!
> While working on putting MariaDB 10.5.5 into Debian I noticed that
> there were a couple of commits that landed more or less on the same
> day as the release was made and "broke" it just before release. Now
> there are surprises in a stable release I need to fix and the
> situation puts extra strain on me.
> It is good that many people participate in maintaining the contents of
> debian/ in the MariaDB Server, because I don't have time to do
> everything. I would however appreciate that when changes are made, I
> would be given a chance to review them. I will review them
> post-release anyway and it would save a lot of trouble, if we can fix
> stuff during the development cycle and not having to patch a
> post-release in order to be able to put it forward to Debian/Ubuntu.
> So, please make PRs of any debian/ changes you make, and feel free to
> add me as the reviewer (or one of the reviewers).
> This policy can also be automated using a .github/CODEOWNERS file, so
> I made a PR about it at https://github.com/MariaDB/server/pull/1650
> Thanks!
> PS. I will deliver a MariaDB 10.5 and MariaDB in Debian status talk at
> https://debconf20.debconf.org/talks/98-whats-new-in-mariadb-server-105-and-galera-4/
> in case anybody is interested to listen in.
> --
> Follow me at @ottokekalainen