← Back to team overview

nova team mailing list archive

Re: Require Pylons, or copy-and-paste its code?

 

I'm not fully convinced we need this yet (see email on the merge
proposal), so I'm going to vote for your ruled out third option of
keeping it simple and writing a really basic wrapper over routes like
you have started. :)

I think Pylons is too heavy, and I really don't like the idea of
copying in parts of modules since you loose one of the reasons you
are using it in the first place - keeping it up to date automatically
between upgrades.

-Eric

On Thu, Aug 12, 2010 at 01:19:29PM -0400, Michael Gundlach wrote:
>    I'd like to use Pylons' WSGIController
>    (http://pylonshq.com/docs/en/0.9.7/modules/controllers_core/#pylons.controllers.core.WSGIController)
>    in Nova.
>    Should I add a dependency on Pylons (seems heavyweight for just one class)
>    or copy WSGIController bodily into Nova (seems like a mortal sin)?
>    I've ruled out the third option, which is "Don't reuse code, and just make
>    our own class that works like WSGIController but isn't as well tested."
>    I'm waffling between the first two options.
>    Michael
> 
>  Confidentiality Notice: This e-mail message (including any attached or
>  embedded documents) is intended for the exclusive and confidential use of the
>  individual or entity to which this message is addressed, and unless otherwise
>  expressly indicated, is confidential and privileged information of Rackspace.
>  Any dissemination, distribution or copying of the enclosed material is prohibited.
>  If you receive this transmission in error, please notify us immediately by e-mail
>  at abuse@xxxxxxxxxxxxx, and delete the original message.
>  Your cooperation is appreciated.

> _______________________________________________
> Mailing list: https://launchpad.net/~nova
> Post to     : nova@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~nova
> More help   : https://help.launchpad.net/ListHelp




References