nova team mailing list archive

[Michael Gundlach <michael.gundlach@xxxxxxxxxxxxx>]

Pardon me for bringing this up -- when I read through WSGIController
carefully, stripping out all the pylons-related stuff, their fancy
dispatching mechanism wasn't actually all that fancy.  I went with a very
simple class after all (see ~gundlach/nova/rsapi:nova/wsgi.py) that doesn't
need to handle all the corner cases related to Pylons.

Michael

On Fri, Aug 13, 2010 at 6:01 AM, Andy Smith <andyster@xxxxxxxxx> wrote:

> I'm a little out of the loop (but catching up slowly) so I don't know why
> it is interesting to use this class, but assuming there is some reason for
> it then I would make pylons a dependency.
>
> If it is at all possible I'd rather not add another dependency when we
> already have multiple examples of a similar class in the current
> dependencies, what are the benefits of the pylon's wsgi lib over, for
> example, eventlet or twisted's?
>
> --andy
>
>
> On Thu, Aug 12, 2010 at 8:53 PM, Jay Pipes <jaypipes@xxxxxxxxx> wrote:
>
>> I would support option #2.  After all, we could always go the route of
>> option #1 if more of the Pylons framework/libraries become useful.
>>
>> -jay
>>
>> On Thu, Aug 12, 2010 at 1:19 PM, Michael Gundlach
>> <michael.gundlach@xxxxxxxxxxxxx> wrote:
>> > I'd like to use Pylons' WSGIController
>> > (
>> http://pylonshq.com/docs/en/0.9.7/modules/controllers_core/#pylons.controllers.core.WSGIController
>> )
>> > in Nova.
>> > Should I add a dependency on Pylons (seems heavyweight for just one
>> class)
>> > or copy WSGIController bodily into Nova (seems like a mortal sin)?
>> > I've ruled out the third option, which is "Don't reuse code, and just
>> make
>> > our own class that works like WSGIController but isn't as well tested."
>> > I'm waffling between the first two options.
>> > Michael
>> >
>> > Confidentiality Notice: This e-mail message (including any attached or
>> > embedded documents) is intended for the exclusive and confidential use
>> of
>> > the
>> > individual or entity to which this message is addressed, and unless
>> > otherwise
>> > expressly indicated, is confidential and privileged information of
>> > Rackspace.
>> > Any dissemination, distribution or copying of the enclosed material is
>> > prohibited.
>> > If you receive this transmission in error, please notify us immediately
>> by
>> > e-mail
>> > at abuse@xxxxxxxxxxxxx, and delete the original message.
>> > Your cooperation is appreciated.
>> >
>> > _______________________________________________
>> > Mailing list: https://launchpad.net/~nova
>> > Post to     : nova@xxxxxxxxxxxxxxxxxxx
>> > Unsubscribe : https://launchpad.net/~nova
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>> >
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~nova
>> Post to     : nova@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~nova
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>


Confidentiality Notice: This e-mail message (including any attached or
embedded documents) is intended for the exclusive and confidential use of the
individual or entity to which this message is addressed, and unless otherwise
expressly indicated, is confidential and privileged information of Rackspace.
Any dissemination, distribution or copying of the enclosed material is prohibited.
If you receive this transmission in error, please notify us immediately by e-mail
at abuse@xxxxxxxxxxxxx, and delete the original message.
Your cooperation is appreciated.