← Back to team overview

nunit-dev team mailing list archive

Re: Review of Windows Installer Commit

 

2009/8/1 Charlie Poole <charlie@xxxxxxxxx>:
> Hi Andreas,
>
> Nice job with the installer. It works. :-)
>
> Comments on your commit follow. Some of them are about
> things you may not have known about since they are not
> well-documented - at least yet. I'll put them in anyway,
> with the understanding that we'll get better at this
> as we go along.
>
> 1. Although it hasn't been discussed yet, we really want
> to review changes before they get in the trunk. No harm
> done in this case, since the installer is new code
> and can't break anything.
>
> Could you set up your own branch under ~achlapsi/nunit-3.0/
> and push to that from now on? I haven't published instructions
> on this yet, but I know you have done it before. ;-)

Please publish those instructions Charlie :)

I'm learning Launchpad/bzr these days, but it is all a "little too
dark" for me as of yet.

>
> Once you do that, you can propose it for merge and we can
> review it beforehand. FWIW, I'll be doing the same. :-)
>
> 2. The tests should be installed as well, as a feature.
>
> 3. The xml file for the framework should be installed too.
>
> 4. There are no docs yet, but we'll want to add them later.
>   Samples as well. So, I think we will want to install
>   from a staging directory as we do for 2.5, rather than
>   directly from the output directory for the build. I'll
>   add a target in the nant script so you can create that
>   install image and use it.
>
> 5. The name of the output package will vary according to
>   the version, e.g: nunit.framework-2.9.1.msi. This is
>   actually controlled by the NAnt script, but it would
>   make sense if your solution used the same convention.
>
> Charlie
>
>> -----Original Message-----
>> From: nunit-dev-bounces+charlie=nunit.com@xxxxxxxxxxxxxxxxxxx
>> [mailto:nunit-dev-bounces+charlie=nunit.com@xxxxxxxxxxxxxxxxxx
>> t] On Behalf Of Andreas Schlapsi
>> Sent: Thursday, July 30, 2009 1:29 PM
>> To: 'NUnit Developer Mailing List'
>> Subject: Re: [Nunit-dev] Installation layout for NUnit V3
>>
>> Hi Charlie,
>>
>> I've just pushed my commits on the installer. There are still
>> some issues with UAC on Vista, which I'd like to solve.
>> Besides, it requires admin privileges for now.
>>
>> I thought about a folder structure similar to your proposal,
>> but I was too conservative. I agree with you. I changed the
>> folder structure of the installer to this:
>>
>> NUnit
>>   Framework
>>     3.0
>>       net-1.1   (if available)
>>       net-2.0   (if available)
>>     3.1
>>       net-1.1
>>       net-2.0
>>
>> If you use the Custom setup type the installer will let you
>> choose to install the assemblies in the GAC. The checkbox
>> appears after the feature tree. The installer defines two
>> components for the framework assembly with conditions which
>> are mutually exclusive. I'm not content with the solution,
>> since it duplicates the definition of the components for the
>> assemblies and it causes some warnings from the ICE validation.
>>
>> Andreas
>>
>>
>> Charlie Poole wrote:
>> > Hi Andreas,
>> >
>> > Cool! I'd like to do a snapshot with it included.
>> >
>> > Putting Framework under nunit-3.0 seems to imply that the version
>> > numbers will be in synch. But imagine some future user who
>> is running
>> > the 3.0 Gui but has tests that use the 3.0, 3.1 and 3.2
>> frameworks -
>> > which we released separately as improvements were added.
>> >
>> > Therefore, I think this should be (something like):
>> >
>> > NUnit
>> >   Framework
>> >      3.0
>> >      3.1
>> >      3.2
>> >   NUnit Gui
>> >      3.0
>> >
>> > OR
>> >
>> > NUnitFramework
>> >    3.0
>> >    3.1
>> >    3.2
>> > NUnit 3.0
>> >
>> > OR
>> >
>> > NUnitFramework
>> >    3.0
>> >    3.1
>> >    3.2
>> > SomeOtherNameForTheGUI 3.0 (or 1.0?)
>> >
>> > Any other ideas?
>> >
>> > Charlie
>> >
>> >
>> >> -----Original Message-----
>> >> From: nunit-dev-bounces+charlie=nunit.com@xxxxxxxxxxxxxxxxxxx
>> >> [mailto:nunit-dev-bounces+charlie=nunit.com@xxxxxxxxxxxxxxxxxx
>> >> t] On Behalf Of Andreas Schlapsi
>> >> Sent: Thursday, July 30, 2009 4:48 AM
>> >> To: 'NUnit Developer Mailing List'
>> >> Subject: Re: [Nunit-dev] Installation layout for NUnit V3
>> >>
>> >> Hi Charlie,
>> >>
>> >> I created a prototype for the NUnit Framework Installer
>> yesterday. It
>> >> packages the NUnit Framework for .NET 1.1 and .NET 2.0
>> (and later for
>> >> .NET 3.5 and 4.0) and suppresses all variants in the feature tree
>> >> without corresponding .NET version installed on the target
>> computer.
>> >>
>> >> It installs the framework assemblies under <Program Files>\NUnit
>> >> 3.0\Framework\net-1.1 or <Program Files>\NUnit
>> 3.0\Framework\net-2.0.
>> >>
>> >> What about documentation? Will the framework documentation be
>> >> separated?
>> >>
>> >> Andreas
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~nunit-dev
>> Post to     : nunit-dev@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~nunit-dev
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~nunit-dev
> Post to     : nunit-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~nunit-dev
> More help   : https://help.launchpad.net/ListHelp
>



-- 
twitter.com/olofb
olofb.wordpress.com
olofb.wordpress.com/tag/english



References