← Back to team overview

nuvola-player-devel team mailing list archive

Re: [Merge] lp:~bizauionica/nuvola-player/grooveshark-popup into lp:nuvola-player

 

Review: Needs Fixing

> I'm a big fan of Git and GitHub (https://github.com/IonicaBizau).

Nuvola Player 3 is hosted at GitHub, so your future contributions will be easier foy you ;-)

Code review:

- Please add yourself to the list of copyright holders at the top of integration.js.
- Is the 60-second interval short enough? As an user, it would be faster to click the resume button myself instead of wainting one minute in the worst case. 5 or 10-second interval might provide better user experience.
-- 
https://code.launchpad.net/~bizauionica/nuvola-player/grooveshark-popup/+merge/229898
Your team Nuvola Player Development is subscribed to branch lp:nuvola-player.


References