nuvola-player-devel team mailing list archive

[Ionică Bizău <bizauionica@xxxxxxxxx>]

Ionică Bizău has proposed merging lp:~bizauionica/nuvola-player/grooveshark-popup into lp:nuvola-player.

Requested reviews:
  Jiří Janoušek (fenryxo)

For more details, see:
https://code.launchpad.net/~bizauionica/nuvola-player/grooveshark-popup/+merge/229898

GrooveShark popup that appears sometimes is annoying.
I added an interval that verifies if the popup appeared and click the <Resume> button if so.

PS: This is my first time when I contribute on Launchpad :-)
-- 
https://code.launchpad.net/~bizauionica/nuvola-player/grooveshark-popup/+merge/229898
Your team Nuvola Player Development is subscribed to branch lp:nuvola-player.

=== modified file 'data/nuvolaplayer/services/grooveshark/integration.js'
--- data/nuvolaplayer/services/grooveshark/integration.js	2013-12-22 18:57:54 +0000
+++ data/nuvolaplayer/services/grooveshark/integration.js	2014-08-07 06:15:50 +0000
@@ -171,6 +171,12 @@
 			throw (this.name + ": " + e.message);
 		}
 	}
+
+	// Close popup that blocks song playing
+	setInterval(function () {
+		var r = document.querySelector("span[data-translate-text='LB_INTERACTION_TIME_RESUME']")
+		r && r.click();
+	}, 1000 * 60);
 	
 	Nuvola.integration = new Integration(); // Singleton ;-)
 })(window._Nuvola);

=== modified file 'src/nuvola/gui/aboutdialog.vala'
--- src/nuvola/gui/aboutdialog.vala	2013-07-15 06:43:38 +0000
+++ src/nuvola/gui/aboutdialog.vala	2014-08-07 06:15:50 +0000
@@ -56,7 +56,8 @@
 			"Janez Troha <janez.troha@xxxxxxxxx>",
 			"Adam Wolfe Gordon <awg@xxxxxx>",
 			"Stefan Lohmaier <stefan.lohmaier@xxxxxxxxxxxxxx>",
-			"Michael Mims <mims.michael@xxxxxxxxx>"
+			"Michael Mims <mims.michael@xxxxxxxxx>",
+			"Ionică Bizău <bizauionica@xxxxxxxxx>"
 		};
 		
 		var box = get_content_area() as Gtk.Box;