openerp-community-reviewer team mailing list archive

["Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code review

Just wondering if the logging is supposed to be there or just there for debugging purposes.
If that's the case, you might want to remove it.

Some PEP8 issues:
__init__.py:3:2: W291 trailing whitespace
__init__.py:19:75: W291 trailing whitespace
__openerp__.py:32:84: W291 trailing whitespace
__openerp__.py:39:78: W291 trailing whitespace
__openerp__.py:49:29: E202 whitespace before ']'
__openerp__.py:52:13: E126 continuation line over-indented for hanging indent
sale_stock.py:3:2: W291 trailing whitespace
sale_stock.py:19:75: W291 trailing whitespace
sale_stock.py:28:1: E302 expected 2 blank lines, found 1
sale_stock.py:33:75: W291 trailing whitespace

Typos:
__openerp__.py:36: In word 'Usualy'
sale_stock.py:39: In word 'ommitted'

Unused imports:
sale_stock.py:23: fields
-- 
https://code.launchpad.net/~camptocamp/sale-wkfl/add-jit-module-for-service-product-jge/+merge/198960
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.