← Back to team overview

openerp-community-reviewer team mailing list archive

[Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management

 

Alexis de Lattre has proposed merging lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management.

Requested reviews:
  Partner and Contact Core Editors (partner-contact-core-editors)

For more details, see:
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564

Add module base_location_geonames_import ; this module adds a wizard to import better zip entries from Geonames (http://download.geonames.org/export/zip/).

Nicolas Bessi suggested on twitter that it should be part of the geospacial addons. But, after thinking about it, my opinion is that this module would be better here, because users of the "base_location" module would have a higher chance of finding this module here than in the geospacial addons.
-- 
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564
Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management.
=== added directory 'base_location_geonames_import'
=== added file 'base_location_geonames_import/__init__.py'
--- base_location_geonames_import/__init__.py	1970-01-01 00:00:00 +0000
+++ base_location_geonames_import/__init__.py	2014-04-07 15:18:55 +0000
@@ -0,0 +1,23 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Base Location Geonames Import module for OpenERP
+#    Copyright (C) 2014 Akretion (http://www.akretion.com)
+#    @author Alexis de Lattre <alexis.delattre@xxxxxxxxxxxx>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import wizard

=== added file 'base_location_geonames_import/__openerp__.py'
--- base_location_geonames_import/__openerp__.py	1970-01-01 00:00:00 +0000
+++ base_location_geonames_import/__openerp__.py	2014-04-07 15:18:55 +0000
@@ -0,0 +1,47 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Base Location Geonames Import module for OpenERP
+#    Copyright (C) 2014 Akretion (http://www.akretion.com)
+#    @author Alexis de Lattre <alexis.delattre@xxxxxxxxxxxx>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+
+{
+    'name': 'Base Location Geonames Import',
+    'version': '0.1',
+    'category': 'Extra Tools',
+    'license': 'AGPL-3',
+    'summary': 'Import better zip entries from Geonames',
+    'description': """
+Base Location Geonames Import
+=============================
+
+This module adds a wizard to import better zip entries from Geonames (http://download.geonames.org/export/zip/).
+
+Please contact Alexis de Lattre from Akretion <alexis.delattre@xxxxxxxxxxxx> for any help or question about this module.
+    """,
+    'author': 'Akretion',
+    'website': 'http://www.akretion.com',
+    'depends': ['base_location'],
+    'external_dependencies': {'python': ['requests', 'unicodecsv']},
+    'data': [
+        'wizard/geonames_import_view.xml',
+    ],
+    'installable': True,
+    'active': False,
+}

=== added directory 'base_location_geonames_import/i18n'
=== added file 'base_location_geonames_import/i18n/base_location_geonames_import.pot'
--- base_location_geonames_import/i18n/base_location_geonames_import.pot	1970-01-01 00:00:00 +0000
+++ base_location_geonames_import/i18n/base_location_geonames_import.pot	2014-04-07 15:18:55 +0000
@@ -0,0 +1,68 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* base_location_geonames_import
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-04-07 15:00+0000\n"
+"PO-Revision-Date: 2014-04-07 15:00+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: base_location_geonames_import
+#: view:better.zip.geonames.import:0
+msgid "Cancel"
+msgstr ""
+
+#. module: base_location_geonames_import
+#: field:better.zip.geonames.import,country_id:0
+msgid "Country"
+msgstr ""
+
+#. module: base_location_geonames_import
+#: code:addons/base_location_geonames_import/wizard/geonames_import.py:64
+#: code:addons/base_location_geonames_import/wizard/geonames_import.py:87
+#, python-format
+msgid "Error:"
+msgstr ""
+
+#. module: base_location_geonames_import
+#: view:better.zip.geonames.import:0
+msgid "For the country selected above, this wizard will delete all the current better zip entries, download the latest version of the list of cities from geonames.org and create new better zip entries."
+msgstr ""
+
+#. module: base_location_geonames_import
+#: code:addons/base_location_geonames_import/wizard/geonames_import.py:88
+#, python-format
+msgid "Got an error %d when trying to download the file %s."
+msgstr ""
+
+#. module: base_location_geonames_import
+#: view:better.zip.geonames.import:0
+msgid "Import"
+msgstr ""
+
+#. module: base_location_geonames_import
+#: model:ir.model,name:base_location_geonames_import.model_better_zip_geonames_import
+msgid "Import Better Zip from Geonames"
+msgstr ""
+
+#. module: base_location_geonames_import
+#: view:better.zip.geonames.import:0
+#: model:ir.actions.act_window,name:base_location_geonames_import.better_zip_geonames_import_action
+#: model:ir.ui.menu,name:base_location_geonames_import.better_zip_geonames_import_menu
+msgid "Import Geonames"
+msgstr ""
+
+#. module: base_location_geonames_import
+#: code:addons/base_location_geonames_import/wizard/geonames_import.py:65
+#, python-format
+msgid "The content of the file doesn't correspond to the selected country."
+msgstr ""
+

=== added file 'base_location_geonames_import/i18n/fr.po'
--- base_location_geonames_import/i18n/fr.po	1970-01-01 00:00:00 +0000
+++ base_location_geonames_import/i18n/fr.po	2014-04-07 15:18:55 +0000
@@ -0,0 +1,68 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* base_location_geonames_import
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-04-07 15:01+0000\n"
+"PO-Revision-Date: 2014-04-07 15:01+0000\n"
+"Last-Translator: Alexis de Lattre <alexis.delattre@xxxxxxxxxxxx>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: base_location_geonames_import
+#: view:better.zip.geonames.import:0
+msgid "Cancel"
+msgstr "Annuler"
+
+#. module: base_location_geonames_import
+#: field:better.zip.geonames.import,country_id:0
+msgid "Country"
+msgstr "Pays"
+
+#. module: base_location_geonames_import
+#: code:addons/base_location_geonames_import/wizard/geonames_import.py:64
+#: code:addons/base_location_geonames_import/wizard/geonames_import.py:87
+#, python-format
+msgid "Error:"
+msgstr "Erreur :"
+
+#. module: base_location_geonames_import
+#: view:better.zip.geonames.import:0
+msgid "For the country selected above, this wizard will delete all the current better zip entries, download the latest version of the list of cities from geonames.org and create new better zip entries."
+msgstr "Pour le pays sélectionné ci-dessus, cet assistant va supprimer toutes les entrées better zip, télécharger la dernière version de la liste des villes depuis geonames.org et créer de nouveaux enregistrements better zip."
+
+#. module: base_location_geonames_import
+#: code:addons/base_location_geonames_import/wizard/geonames_import.py:88
+#, python-format
+msgid "Got an error %d when trying to download the file %s."
+msgstr "Erreur %d reçue suite à la tentative de téléchargement du fichier %s."
+
+#. module: base_location_geonames_import
+#: view:better.zip.geonames.import:0
+msgid "Import"
+msgstr "Importer"
+
+#. module: base_location_geonames_import
+#: model:ir.model,name:base_location_geonames_import.model_better_zip_geonames_import
+msgid "Import Better Zip from Geonames"
+msgstr "Import Better Zip depuis Geonames"
+
+#. module: base_location_geonames_import
+#: view:better.zip.geonames.import:0
+#: model:ir.actions.act_window,name:base_location_geonames_import.better_zip_geonames_import_action
+#: model:ir.ui.menu,name:base_location_geonames_import.better_zip_geonames_import_menu
+msgid "Import Geonames"
+msgstr "Importer Geonames"
+
+#. module: base_location_geonames_import
+#: code:addons/base_location_geonames_import/wizard/geonames_import.py:65
+#, python-format
+msgid "The content of the file doesn't correspond to the selected country."
+msgstr "Le contenu du fichier ne correspond pas au pays sélectionné."
+

=== added directory 'base_location_geonames_import/wizard'
=== added file 'base_location_geonames_import/wizard/__init__.py'
--- base_location_geonames_import/wizard/__init__.py	1970-01-01 00:00:00 +0000
+++ base_location_geonames_import/wizard/__init__.py	2014-04-07 15:18:55 +0000
@@ -0,0 +1,23 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Base Location Geonames Import module for OpenERP
+#    Copyright (C) 2014 Akretion (http://www.akretion.com)
+#    @author Alexis de Lattre <alexis.delattre@xxxxxxxxxxxx>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import geonames_import

=== added file 'base_location_geonames_import/wizard/geonames_import.py'
--- base_location_geonames_import/wizard/geonames_import.py	1970-01-01 00:00:00 +0000
+++ base_location_geonames_import/wizard/geonames_import.py	2014-04-07 15:18:55 +0000
@@ -0,0 +1,125 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    Base Location Geonames Import module for OpenERP
+#    Copyright (C) 2014 Akretion (http://www.akretion.com)
+#    @author Alexis de Lattre <alexis.delattre@xxxxxxxxxxxx>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm, fields
+from openerp.tools.translate import _
+import requests
+import tempfile
+import StringIO
+import unicodecsv
+import zipfile
+import os
+import logging
+
+logger = logging.getLogger(__name__)
+
+
+class better_zip_geonames_import(orm.TransientModel):
+    _name = 'better.zip.geonames.import'
+    _description = 'Import Better Zip from Geonames'
+
+    _columns = {
+        'country_id': fields.many2one('res.country', 'Country', required=True),
+    }
+
+    def _prepare_better_zip(
+            self, cr, uid, row, country_id, states, context=None):
+        '''This function is designed to be inherited'''
+        state_id = False
+        if states and row[4] and row[4] in states:
+            state_id = states[row[4].upper()]
+        vals = {
+            'name': row[1],
+            'city': row[2],
+            'state_id': state_id,
+            'country_id': country_id,
+            }
+        return vals
+
+    def create_better_zip(
+            self, cr, uid, row, country_id, country_code, states,
+            context=None):
+        bzip_id = False
+        if row[0] != country_code:
+            raise orm.except_orm(
+                _('Error:'),
+                _("The content of the file doesn't correspond to the "
+                    "selected country."))
+        logger.debug('ZIP = %s - City = %s' % (row[1], row[2]))
+        if row[0] == 'FR' and 'CEDEX' in row[1]:
+            return False
+        if row[1] and row[2]:
+            vals = self._prepare_better_zip(
+                cr, uid, row, country_id, states, context=context)
+            bzip_id = self.pool['res.better.zip'].create(
+                cr, uid, vals, context=context)
+        return bzip_id
+
+    def run_import(self, cr, uid, ids, context=None):
+        assert len(ids) == 1, 'Only one ID for the better zip import wizard'
+        bzip_obj = self.pool['res.better.zip']
+        wizard = self.browse(cr, uid, ids[0], context=context)
+        country_id = wizard.country_id.id
+        country_code = wizard.country_id.code.upper()
+        url = 'http://download.geonames.org/export/zip/%s.zip' % country_code
+        logger.info('Starting to download %s' % url)
+        res_request = requests.get(url)
+        if res_request.status_code != requests.codes.ok:
+            raise orm.except_orm(
+                _('Error:'),
+                _('Got an error %d when trying to download the file %s.')
+                % (res_request.status_code, url))
+        bzip_ids_to_delete = bzip_obj.search(
+            cr, uid, [('country_id', '=', country_id)], context=context)
+        if bzip_ids_to_delete:
+            bzip_obj.unlink(cr, uid, bzip_ids_to_delete, context=context)
+            logger.info(
+                '%d better zip entries deleted for country %s'
+                % (len(bzip_ids_to_delete), wizard.country_id.name))
+        state_ids = self.pool['res.country.state'].search(
+            cr, uid, [('country_id', '=', country_id)], context=context)
+        states = {}
+        # key = code of the state ; value = ID of the state in OpenERP
+        if state_ids:
+            states_r = self.pool['res.country.state'].read(
+                cr, uid, state_ids, ['code', 'country_id'], context=context)
+            for state in states_r:
+                states[state['code'].upper()] = state['id']
+        f_geonames = zipfile.ZipFile(StringIO.StringIO(res_request.content))
+        tempdir = tempfile.mkdtemp(prefix='openerp')
+        f_geonames.extract('%s.txt' % country_code, tempdir)
+        logger.info('The geonames zipfile has been decompressed')
+        data_file = open(os.path.join(tempdir, '%s.txt' % country_code), 'r')
+        data_file.seek(0)
+        logger.info(
+            'Starting to create the better zip entries %s state information'
+            % (states and 'with' or 'without'))
+        for row in unicodecsv.reader(
+                data_file, encoding='utf-8', delimiter='	'):
+            self.create_better_zip(
+                cr, uid, row, country_id, country_code, states,
+                context=context)
+        data_file.close()
+        logger.info(
+            'The wizard to create better zip entries from geonames '
+            'has been successfully completed.')
+        return True

=== added file 'base_location_geonames_import/wizard/geonames_import_view.xml'
--- base_location_geonames_import/wizard/geonames_import_view.xml	1970-01-01 00:00:00 +0000
+++ base_location_geonames_import/wizard/geonames_import_view.xml	2014-04-07 15:18:55 +0000
@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+    Copyright (C) 2014 Akretion (http://www.akretion.com/)
+    @author: Alexis de Lattre <alexis.delattre@xxxxxxxxxxxx>
+    The licence is in the file __openerp__.py
+-->
+
+<openerp>
+<data>
+
+<record id="better_zip_geonames_import_form" model="ir.ui.view">
+    <field name="name">asterisk.server.company</field>
+    <field name="model">better.zip.geonames.import</field>
+    <field name="arch"  type="xml">
+        <form string="Import Geonames" version="7.0">
+            <group name="main">
+                <field name="country_id"/>
+                <label string="For the country selected above, this wizard will delete all the current better zip entries, download the latest version of the list of cities from geonames.org and create new better zip entries."
+                    colspan="2" name="import-help"/>
+            </group>
+            <footer>
+                <button name="run_import" type="object"
+                    class="oe_highlight" string="Import"/>
+                <button special="cancel" string="Cancel" class="oe_link"/>
+            </footer>
+        </form>
+    </field>
+</record>
+
+<record id="better_zip_geonames_import_action" model="ir.actions.act_window">
+    <field name="name">Import Geonames</field>
+    <field name="res_model">better.zip.geonames.import</field>
+    <field name="view_type">form</field>
+    <field name="view_mode">form</field>
+    <field name="target">new</field>
+</record>
+
+<menuitem id="better_zip_geonames_import_menu"
+    action="better_zip_geonames_import_action"
+    parent="base.menu_localisation"
+    sequence="50"/>
+
+</data>
+</openerp>


Follow ups