Hello Christophe,
We are looking for blueprint, what you think, can we create extra
account.move.line for additional discount,
to track and reconcile it properly. To make it more standard for accounting.
On Tue, Sep 4, 2012 at 12:49 PM, Christophe Combelles <ccomb@xxxxxxx
<mailto:ccomb@xxxxxxx>> wrote:
you're 100% right, I'm was just doing some experiments, we really need to
write down what needs to be done because it's not fully clear for me :
(should we propagate the discount to the purchase, when and what should we
discount, etc.?).
Le 04/09/2012 04:23, satyamitra maan a écrit :
Nice ,
I would like to suggest that we should start with some kind of global
blueprint. So that robin and his team can put some efforts to achieve
the global required result. Since what we developed is just for
specific case for one of our customer .
Robin please collect all the specifications in previous threads of
this email and submit the required to community for refine, to be able
to create a clear blueprint.
Regards
Satyamitra
On 9/4/12, Georges Racinet<gracinet@xxxxxxxxx
<mailto:gracinet@xxxxxxxxx>> wrote:
On Sep 3, 2012, at 9:14 PM, Christophe Combelles wrote:
Hi,
Ok, I just created a project and pushed a branch, I've already
created YML tests for a basic scenario and will update it soon.
You just have to join the team of the same name to be maintainer of
the project as well (additional-discount)
https://launchpad.net/__additional-discount
<https://launchpad.net/additional-discount>
Great !
I added a continuous testing case in our public buildbot:
http://buildbot.anybox.fr/__builders/6.1-additional-__discount-postgresql-9.1
<http://buildbot.anybox.fr/builders/6.1-additional-discount-postgresql-9.1>
One can see your new yml test in these logs :
http://buildbot.anybox.fr/__builders/6.1-additional-__discount-postgresql-9.1/__builds/1/steps/testing/logs/__test
<http://buildbot.anybox.fr/builders/6.1-additional-discount-postgresql-9.1/builds/1/steps/testing/logs/test>
For the record:
http://bazaar.launchpad.net/~__anybox/anybox.buildbot.__openerp/first/revision/168
<http://bazaar.launchpad.net/~anybox/anybox.buildbot.openerp/first/revision/168>
http://bazaar.launchpad.net/~__anybox/anybox.buildbot.__openerp/first/revision/169
<http://bazaar.launchpad.net/~anybox/anybox.buildbot.openerp/first/revision/169>
Cheers,
Le 03/09/2012 19:02, Robin Bahadur a écrit :
Hello All,
Thanks alot for bringing this opportunity, yes definitely we
could
create a
launchpad project,
so that we can easily update it, and do bug tracking and
resolution
also.
On Mon, Sep 3, 2012 at 4:37 PM, Christophe
Combelles<ccomb@xxxxxxx <mailto:ccomb@xxxxxxx>
<mailto:ccomb@xxxxxxx <mailto:ccomb@xxxxxxx>>> wrote:
Hi Satyamitra,
Did you have the opportunity to update the final revision ?
Do you think we could create a launchpad project for this
module, so we can
host branches at the same place and use the bug tracker ?
Christophe
Le 29/08/2012 18:21, satyamitra maan a écrit :
Dear friends,
Just looked at this discussion, As the author of
this module
I take
full responsibility for this mistake , somehow we
missed to
update the
final revision, will check with My team and update it
tomorrow
itself.
Apologize again for our ignorance.
Thanks
Satyamitra maan
Ph +91 9990539414
Skype: maansatyamitra
On 8/29/12, Georges Racinet<gracinet@xxxxxxxxx
<mailto:gracinet@xxxxxxxxx>
<mailto:gracinet@xxxxxxxxx <mailto:gracinet@xxxxxxxxx>>>
wrote:
Hi Alexis,
On 08/29/2012 02:05 PM, Alexis de Lattre wrote:
I had a look at your module
"additional_discount"
for OpenERP
6.1, and I
was surprised to see that, when you have an
"additionnal
discount" on an
invoice, it doesn't impact the account move
that is
generated
when you
validate the invoice. You should warn users
about
this and state
clearly
that this module is not suitable for
companies that
use OpenERP
as their
accounting system.
Christophe may develop further on that, but as
far as I
understand it,
we did the bare minimum to port this existing
community
module to
OpenERP 6.1 (I did lately a bit of refactoring
that has
yet to be
validated in real life, but should be
iso-functional).
So, thanks for the very useful remarks, we'll
take them
into account
sooner or later. Would you be so kind to file
them as
launchpad tickets?
I'd like also to stress that we will of course
welcome
pull requests
heartily.
I also noticed that the discount is not
copied from
sale order to
invoice when the invoice is based on deliveries
(same when the
invoice
of the PO is generated from the deliveries).
P.S. : in the code of sale.py, instead of
inheriting
_make_invoice(),
you should inherit _prepare_invoice()
because it
provides better
performances :
- when you inherit _make_invoice(), the
generation
of the
invoice from
the sale order will do both a create() and a
write(), which
makes 2 SQL
operations
- when you inherit _prepare_invoice(), it
will only
do a
create(), so
only 1 SQL operation (_prepare_invoice()
allows you
to modify
the vals
that are used in the create()).
These _prepare_* functions are new in
OpenERP 6.1
and have been
contributed by Akretion through merge
proposals. You
will find
them also
for invoice lines from SO and invoice lines
from PO,
when the
invoice is
generated from PO/SO and when the invoice is
generated from the
picking.
Okay, improvements specific to 6.1, no wonder
we don't
have them yet.
One question though : are they available in all 6.1
versions ?
This function _prepare_invoice() doesn't
exist on
purchase
orders yet (I
plan to do the merge proposal for this some
day...)
Regards,
Thanks again
--
Georges Racinet
Anybox SAS, http://anybox.fr
Bureau: 09 53 53 72 97 Portable: 06 51 32 07 27
GPG: 0x33AB0A35, sur serveurs publics
___________________________________________________
Mailing list:
https://launchpad.net/~____openerp-community
<https://launchpad.net/~__openerp-community>
<https://launchpad.net/~__openerp-community
<https://launchpad.net/~openerp-community>>
Post to :
openerp-community@lists.__laun__chpad.net <http://launchpad.net>
<mailto:openerp-community@__lists.launchpad.net
<mailto:openerp-community@xxxxxxxxxxxxxxxxxxx>>
Unsubscribe :
https://launchpad.net/~____openerp-community
<https://launchpad.net/~__openerp-community>
<https://launchpad.net/~__openerp-community
<https://launchpad.net/~openerp-community>>
More help :
https://help.launchpad.net/____ListHelp
<https://help.launchpad.net/__ListHelp>
<https://help.launchpad.net/__ListHelp
<https://help.launchpad.net/ListHelp>>
--
Thanks& Regards
Robin Bahadur
( CTO OpenERP4you )
Georges Racinet
Anybox SAS, http://anybox.fr
Bureau: 09 53 53 72 97 Portable: 06 51 32 07 27
GPG: 0x33AB0A35, sur serveurs publics
_________________________________________________
Mailing list: https://launchpad.net/~__openerp-community
<https://launchpad.net/~openerp-community>
Post to : openerp-community@lists.__launchpad.net
<mailto:openerp-community@xxxxxxxxxxxxxxxxxxx>
Unsubscribe : https://launchpad.net/~__openerp-community
<https://launchpad.net/~openerp-community>
More help : https://help.launchpad.net/__ListHelp
<https://help.launchpad.net/ListHelp>
_________________________________________________
Mailing list: https://launchpad.net/~__openerp-community
<https://launchpad.net/~openerp-community>
Post to : openerp-community@lists.__launchpad.net
<mailto:openerp-community@xxxxxxxxxxxxxxxxxxx>
Unsubscribe : https://launchpad.net/~__openerp-community
<https://launchpad.net/~openerp-community>
More help : https://help.launchpad.net/__ListHelp
<https://help.launchpad.net/ListHelp>
--
Thanks & Regards
Robin Bahadur
( CTO OpenERP4you )
