← Back to team overview

openerp-community team mailing list archive

Re: [Merge] lp:~openerp-community/openobject-addons/gscom-70-l10n-vn into lp:openobject-addons/7.0

 

Review: Needs Fixing

Hi Tran,

thank you for updating the code. I still have some comments:

Indentation still not correct, the lines inside the record tags should be indented more than those tags.

Account types are now 'noupdate', but so are account templates. You will want to include these in their own data tag without this attribute.

Other changes ok.


-- 
https://code.launchpad.net/~openerp-community/openobject-addons/gscom-70-l10n-vn/+merge/141526
Your team OpenERP Community is subscribed to branch lp:~openerp-community/openobject-addons/gscom-70-l10n-vn.


Follow ups

References