← Back to team overview

openerp-community team mailing list archive

Re: Removing inactive members from the reviewers team

 

Raphael,
I know very well you are a contributor, and I think most people do. If you
say you're willing to review somewhat soon, that's fine by me.

Leo

On Tue, Sep 10, 2013 at 5:10 PM, Raphael Valyi <rvalyi@xxxxxxxxx> wrote:

> Hello Joël (and others)
>
> As you listed me among the "inactive" reviewers, here is my answer: yes
> I've been less active recently as a reviewer. But I ask you to consider
> that was temporary and not forget that I did crucial activities for this
> project even recently.
> Let me remind you that's me (with you) that started the movement to
> modularize the extra-addons repo into these project one year ago, that's
> even me who made the Ruby extraction script that allowed changing the
> branch topology without loosing the history of the project (since there is
> no decent equivalent of git-subtree as we learnet hardly).
>
> As a reviewer, I did a few reviews and merges recently (fiscal rules,
> bugs, product attributes) still and made may be 4 MP to these "reviewer"
> projects since the beginning of the year (and many more that aren't in tht
> project set). For instance for the refactor of the product attributes,
> which is the basis of the catalog synchro your are using in the Magento
> connector... I also tried hard to refactor product_image recently but were
> unable at the end to reuse OpenERP core core of ir.attachement
> unfortunately.
> But more should come. I'm also one of those that lost most time with the
> contact issue in v7, which I'm sure is one of the things we lost the most
> time with v7.
>
> Also, it's not because I didn't do many review recently that I did
> nothing. In fact I took care of our Brazilian localization for v7. But when
> doing that, I started to want loosing time with bzr in general and with
> untested project. That's why I spent quite some time studying the git bzr
> synchro. Now, I'm proposing to create git mirrors with automatic Travis
> tests for all these community projects. That's not a review, but I'm sure
> that will be a great benefit for the project, right?
> As a preview one can see how our localization is publicly tested after
> every commit https://travis-ci.org/openerpbrasil/l10n_br_core
> I recently experimented to test OCB branches automatically but had to
> pause that because of this issue:
> https://github.com/travis-ci/travis-ci/issues/902
> But I will soon make work around with an extra repo just for these OCB
> branches.
>
> So, please consider my recent low reviewer activity as a refusal to build
> on sand and investment in side projects aiming at consolidating our work.
> In the same line, because I prefer reusing proven standards that have a
> valid business model of their own instead of re-inventing the wheel, I
> recently spent a significant amount of time building and testing the OOOR,
> OOOREST, AKTOOOR and ERPIFY (see https://github.com/akretion ) Ruby
> projects that wire OpenERP to Ruby or Rails at different levels (with a
> great case here in Brazil coming around the corner). This IMHO is smarter
> than trying to invent a non scalable web-framework around OpenERP which
> should focus on being first a good ERP I think.
>
> So, just asking for a bit of patience, now that this and a few other
> administrative things are in place at Akretion I'm going to take a more
> active part again in the reviews and I'm sure you'll see that soon. In fact
> I should start soon with reviews around variants and account_payment.
>
> Regards and kudos for the work meanwhile.
>
>
> --
> Raphaël Valyi
> Founder and consultant
> http://twitter.com/rvalyi <http://twitter.com/#!/rvalyi>
> +55 21 2516 2954
> www.akretion.com
>
>
>
>
>
>
> On Tue, Sep 10, 2013 at 11:44 AM, Joël Grand-Guillaume <
> joel.grandguillaume@xxxxxxxxxxxxxx> wrote:
>
>> Dear Pedro,
>>
>>
>> No written rule here, but it's commonly accepted between us. I think the
>> way is to be sponsored by an existing member of the reviewer team and let
>> him ask for your participation to others (through the mailing list), as it
>> just happened for Holger Brunn.
>>
>> Regards,
>>
>> Joël
>>
>>
>>
>> On Tue, Sep 10, 2013 at 4:40 PM, Pedro Manuel Baeza Romero <
>> pedro.baeza@xxxxxxxxx> wrote:
>>
>>> I take this opportunity to ask you to include me<https://launchpad.net/~pedro.baeza>as community reviewer or tell me what is the method to do it, because I'm
>>> collaborating in MP reviews for a while.
>>>
>>> Regards.
>>>
>>>
>>> 2013/9/10 Er. Jay Vora <jay.vora4ce@xxxxxxxxx>
>>>
>>> Team,
>>>>
>>>> https://code.launchpad.net/~serpentcs is a team
>>>> https://code.launchpad.net/~serpent-consulting-services is a member
>>>> who is active.
>>>>
>>>> Please allow  https://code.launchpad.net/~serpent-consulting-services
>>>>
>>>> Thanks.
>>>>
>>>>
>>>> On Tue, Sep 10, 2013 at 7:58 PM, Serpent Consulting Services <
>>>> serpentcs.lp@xxxxxxxxx> wrote:
>>>>
>>>>>  Dears,
>>>>>
>>>>> We do contribute and review too, but not all.
>>>>> Thanks.
>>>>>
>>>>> On Tuesday 10 September 2013 07:46 PM, Eric Caudal wrote:
>>>>>
>>>>> Agree on both.
>>>>> I personally cannot really participate in a code review (I am not a
>>>>> developer) but can only comment some time to time to functional decisions.
>>>>> I dont know what that makes me ;)
>>>>>
>>>>> Eric Caudal*CEO*
>>>>> --*Elico Corporation, Shanghai branchOpenERP Premium Certified Training Partner *
>>>>> Cell: + 86 186 2136 1670
>>>>> Office: + 86 21 6211 8017/27/37
>>>>> Skype: elico.corperic.caudal@elico-corp.comhttp://www.elico-corp.com
>>>>>
>>>>> [image: Elico Corp]
>>>>> On 10/09/2013 21:55, Joël Grand-Guillaume wrote:
>>>>>
>>>>>   Dear Community,
>>>>>
>>>>>
>>>>>  I'm concerned by having various people in the OpenERP Community
>>>>> Reviewer team that didn't even make a single comment from 2012-11-20,
>>>>> the date of his creation.
>>>>>
>>>>>  I can perfectly understand that it's difficult to make room and find
>>>>> space for that, but in the meanwhile, it's not fair to include people that
>>>>> doesn't take time to review other's work. Being part of that team is a
>>>>> chance but also have his responsibility.
>>>>>
>>>>>  Currently, no rules define any approval nor removal of participant
>>>>> and a minimum of contribution should be required and define in the future.
>>>>> From his beginning, we just discussed and vote through the mailing list,
>>>>> and so far, it's working.
>>>>>
>>>>>  Here is the list of people that are part of the Reviewer team and
>>>>> never found the time to contribute (I mean to the review process, nothing
>>>>> to do with their community work). Please, do not see any shame in the
>>>>> following list of names, it's just a fact and doesn't affect any skills or
>>>>> value:
>>>>>
>>>>> Borja López Soilán : https://launchpad.net/~borjals
>>>>> Jordi Esteve : jesteve@xxxxxxxxxxxxxxx
>>>>> Raphaël Valyi : https://launchpad.net/~rvalyi
>>>>>  Olivier Dony: odo@xxxxxxxxxxx
>>>>>
>>>>>   I suggest to give them a chance to say if they still want to be
>>>>> part of the team by responding to this email. For those who doesn't, I
>>>>> suggest to remove them from the list of community reviewers.
>>>>>
>>>>> 1) Are you agree with this ?
>>>>>
>>>>>
>>>>>  Then, I want to avoid having team in there, I know we discussed
>>>>> that, but we also need to be fair here. I rather prefer to have named
>>>>> person as member of the reviewer team, so I'm in favor of removing:
>>>>>
>>>>>  * Camptocamp Community Reviewer
>>>>>  * Vauxoo Community Reviewer
>>>>>  * Serpent Consulting Services
>>>>>
>>>>>  And replacing them by the list of person using their LP login.
>>>>>
>>>>>  2) Are you agree with this ?
>>>>>
>>>>>
>>>>>  Thanks for your opinion/answer here.
>>>>>
>>>>>
>>>>>  Best regards,
>>>>>
>>>>>
>>>>>
>>>>> Joël
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>>
>>>>>   *camptocamp*
>>>>> INNOVATIVE SOLUTIONS
>>>>> BY OPEN SOURCE EXPERTS
>>>>>
>>>>>  *Joël Grand-Guillaume*
>>>>> Division Manager
>>>>> Business Solutions
>>>>>
>>>>>  +41 21 619 10 28
>>>>> www.camptocamp.com
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~openerp-community
>>>>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~openerp-community
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~openerp-community
>>>>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~openerp-community
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> Thanks,
>>>>> Regards,
>>>>>
>>>>> Serpent Consulting Services.
>>>>> Web : http://www.serpentcs.com
>>>>> Twitter: jaynvora, husendaudi
>>>>> Skype: jaynvora, husen.daudi
>>>>> Blog : http://www.serpentcs.com/blog
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~openerp-community
>>>>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~openerp-community
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Thanks,
>>>> Regards,
>>>>
>>>> *Er. Jay Vora*
>>>> M : 91 - 9879354457.
>>>> (Not miles, just an email away...)
>>>> Twitter <http://twitter.com/#%21/jaynvora> Facebook<http://www.facebook.com/jaynvora>
>>>> LinkedIn <http://www.linkedin.com/in/jaynvora> Blogger<http://jayvora.blogspot.com>
>>>> "No Seconds to be Wasted for Formalities, I have a lot to Execute !" -
>>>> Jay Vora
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~openerp-community
>>>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~openerp-community
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~openerp-community
>>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~openerp-community
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>>
>> --
>>
>>
>> *camptocamp*
>> INNOVATIVE SOLUTIONS
>> BY OPEN SOURCE EXPERTS
>>
>> *Joël Grand-Guillaume*
>> Division Manager
>> Business Solutions
>>
>> +41 21 619 10 28
>> www.camptocamp.com
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~openerp-community
>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~openerp-community
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References