openerp-community team mailing list archive

[Guewen Baconnier <guewen.baconnier@xxxxxxxxxxxxxx>]

Hi Ana,

The thread is quite diverging here, as the initial topic was the 
inactivation of the reviewers team, this is an interesting topic though.


Some thoughts:

On 09/10/2013 10:28 PM, Ana Juaristi wrote:
> Several comments:
 <snip>
> About functional test.. some doubts:
> Is there any kind of notification or priorities on testing tasks? I
> mean... on community branches and projects could exists very specific
> modules that only people who built them or customers using, can now
> exactly what functional behavior is expected to have.
So I tend to think that such modules (only used by a single author) have 
no place in the community addons. That's also why we need functional 
reviewers I think, they are the ones who can say if a module is generic 
enough to be part of the community addons.

> If module is not
> very well documented on functional side, with clear blueprint,
> requirements, users manuals, test cases... and so on...  it can be
> extremly dificult for a consultant to test it.
If a module is not sufficiently documented to be used (even more by a 
specialist!), it means that the functional reviewer has already proven 
her usefulness. She has to put the review in 'Needs fixing' and ask for 
more documentation (at least in __openerp__.py).

> For me, testing is not only that module installs and there is no
> tracebacks on screen but it should right calculate, right show
> information, right follow workflows... It can be somehow automated with
> tests but I think a human eye has to validate everything is right and
> try to break it somehow.
Correctly testing a module takes time, for sure. Now, we should maybe 
find the right balance between 'just install' and a 'full testing'. This 
looks maybe like: 'this module is generic and useful for the community, 
the concepts it put in place are proper and sounds healthy'.
I mean, we won't be able to prevent all bugs, but 1. they can be 
automatically tested 2. they can be fixed. The most important if we lack 
time is first to ensure that the problems are resolved the right way 
even if the details are not perfect.

> So.. if we try making this task for any module published on community
> branches, it can be a hell.
That's also a reason to motivate functional reviewers, the more they 
are, the less the task will be vast. We should also find ways to improve 
their life, like automatic builds of OpenERP with the modules to test.

  <snip>
> On the other side, there is very generic modules, small functionality
> that can be easily tested without needing to much documentation or
> knowhow. We should priorice these first I think. I'm not sure...
I fear that if we do that, only smaller modules will be tested.

> Thank you everybody:
> Ana


--
Guewen Baconnier
Business Solutions Software Developer

Camptocamp SA
PSE A, CH-1015 Lausanne
Phone: +41 21 619 10 39
Office: +41 21 619 10 10
http://www.camptocamp.com/