← Back to team overview

openerp-community team mailing list archive

Re: Removing inactive members from the reviewers team

 

Several comments:
First, I would vote Raphael to be reviewer and not remove him from list.
If it can help, I can also confirm Pedro as most active spanish
localization contributor for 7.0 and if possible contribute to Nhomar's
sponsor for him!! :)

About reviewers need, I would (personally) also prefer making functional
than technical review myself but I could also dedicate someone of our
technical team if necesary and you agree on that.

About functional test.. some doubts:
Is there any kind of notification or priorities on testing tasks? I mean...
on community branches and projects could exists very specific modules that
only people who built them or customers using, can now exactly what
functional behavior is expected to have. If module is not very well
documented on functional side, with clear blueprint, requirements, users
manuals, test cases... and so on...  it can be extremly dificult for a
consultant to test it.
For me, testing is not only that module installs and there is no tracebacks
on screen but it should right calculate, right show information, right
follow workflows... It can be somehow automated with tests but I think a
human eye has to validate everything is right and try to break it somehow.
So.. if we try making this task for any module published on community
branches, it can be a hell.  About this... we have got a kind of POC for
extending modules doc that maybe could help. Sorry because it's made for
6.1. We can migrate to 7.0 if you like it. I promise sending you a little
video about idea and the branche to download for next week. ( I just
promise... I will try to be on time)

On the other side, there is very generic modules, small functionality that
can be easily tested without needing to much documentation or knowhow. We
should priorice these first I think. I'm not sure...
Thank you everybody:
Ana


2013/9/10 Joël Grand-Guillaume <joel.grandguillaume@xxxxxxxxxxxxxx>

> Review are most of the time technical, but I'm strongly in favor of having
> functionnal and testing point of view on them. So your contribution and
> comments are really welcome from my point of view.
>
> Any other opinion here ?
>
>
>
> On Tue, Sep 10, 2013 at 4:16 PM, Eric Caudal <eric.caudal@xxxxxxxxxxxxxx>wrote:
>
>>  Agree on both.
>> I personally cannot really participate in a code review (I am not a
>> developer) but can only comment some time to time to functional decisions.
>> I dont know what that makes me ;)
>>
>> Eric Caudal*CEO*
>> --*Elico Corporation, Shanghai branchOpenERP Premium Certified Training Partner *
>> Cell: + 86 186 2136 1670
>> Office: + 86 21 6211 8017/27/37
>> Skype: elico.corperic.caudal@elico-corp.comhttp://www.elico-corp.com
>>
>> [image: Elico Corp]
>> On 10/09/2013 21:55, Joël Grand-Guillaume wrote:
>>
>>   Dear Community,
>>
>>
>>  I'm concerned by having various people in the OpenERP Community Reviewer
>> team that didn't even make a single comment from 2012-11-20, the date of
>> his creation.
>>
>>  I can perfectly understand that it's difficult to make room and find
>> space for that, but in the meanwhile, it's not fair to include people that
>> doesn't take time to review other's work. Being part of that team is a
>> chance but also have his responsibility.
>>
>>  Currently, no rules define any approval nor removal of participant and
>> a minimum of contribution should be required and define in the future. From
>> his beginning, we just discussed and vote through the mailing list, and so
>> far, it's working.
>>
>>  Here is the list of people that are part of the Reviewer team and never
>> found the time to contribute (I mean to the review process, nothing to do
>> with their community work). Please, do not see any shame in the
>> following list of names, it's just a fact and doesn't affect any skills or
>> value:
>>
>> Borja López Soilán : https://launchpad.net/~borjals
>> Jordi Esteve : jesteve@xxxxxxxxxxxxxxx
>> Raphaël Valyi : https://launchpad.net/~rvalyi
>>  Olivier Dony: odo@xxxxxxxxxxx
>>
>>   I suggest to give them a chance to say if they still want to be part
>> of the team by responding to this email. For those who doesn't, I suggest
>> to remove them from the list of community reviewers.
>>
>> 1) Are you agree with this ?
>>
>>
>>  Then, I want to avoid having team in there, I know we discussed that,
>> but we also need to be fair here. I rather prefer to have named person as
>> member of the reviewer team, so I'm in favor of removing:
>>
>>  * Camptocamp Community Reviewer
>>  * Vauxoo Community Reviewer
>>  * Serpent Consulting Services
>>
>>  And replacing them by the list of person using their LP login.
>>
>>  2) Are you agree with this ?
>>
>>
>>  Thanks for your opinion/answer here.
>>
>>
>>  Best regards,
>>
>>
>>
>> Joël
>>
>>
>>
>>
>>
>> --
>>
>>
>>   *camptocamp*
>> INNOVATIVE SOLUTIONS
>> BY OPEN SOURCE EXPERTS
>>
>>  *Joël Grand-Guillaume*
>> Division Manager
>> Business Solutions
>>
>>  +41 21 619 10 28
>> www.camptocamp.com
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~openerp-community
>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~openerp-community
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~openerp-community
>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~openerp-community
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
>
> --
>
>
> *camptocamp*
> INNOVATIVE SOLUTIONS
> BY OPEN SOURCE EXPERTS
>
> *Joël Grand-Guillaume*
> Division Manager
> Business Solutions
>
> +41 21 619 10 28
> www.camptocamp.com
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
CEO Avanzosc, S.L <http://www.avanzosc.es> : Office phone / Tfono oficina:
(+34) 943 02 69 02
Ana Juaristi Olalde <http://www.anajuaristi.com/>: Personal phone: 677 93
42 59. User/usuario skype: Avanzosc
www.openerpsite.com


*El contenido de esta comunicación y de toda su documentación anexa es
confidencial y se dirige exclusivamente a su destinatario. El uso no
autorizado de esta información está prohibido por la legislación vigente.
Si usted no es el destinatario le rogamos nos lo indique, no comunique su
contenido a terceros y proceda a su destrucción. Disculpe las molestias que
le haya ocasionado la recepción indebida de este e-mail. Sus datos figuran
en un fichero cuyo titular es Avanzosc, S.L., a quien usted puede dirigirse
para ejercer sus derechos de acceso, rectificación, cancelación y oposición
en Julio Urkijo, 32, 20720, Azkoitia (Gipuzkoa), Tef. 943 02 69 02 -
administracion@xxxxxxxxxxxx <soporte@xxxxxxxxxxxx> *
* *

*Komunikazio honen edukia eta dokumentazio erantsia konfidentziala da eta
hartzaileak bakarrik jaso beharko luke. Indarrean dagoen legeriak debekatu
egiten du bertan eskainitako informazioa baimenik gabe erabiltzea.
Komunikazioa zuri iritsi bazaizu, baina zu ez bazara hartzailea, mesedez,
guri jakinarazi, eta jasotako informazioa ez inori jakinarazi eta suntsitu.
Barkatu okerreko email hau jasotzeak eragindako eragozpenak. Zure datuak
Avanzosc, S.L. enpresaren fitxategietan sartuta daude. Zure datuak atzitzea
eska dezakezu, bai eta, datuak zuzentzea, ezereztea eta tratamenduari aurka
egitea ere. Horretarako, enpresara jo dezakezu, helbide honetan: Julio
Urkijo, 32, 20720, Azkoitia (Gipuzkoa), telefonoa: 943 02 69 02 - **
administracion@xxxxxxxxxxxx <soporte@xxxxxxxxxxxx> *
*This message and all documents attached to it are confidential and
intended only for the person or entity to which it is addressed. Any use of
this information by unauthorised persons is prohibited under current
legislation. If you received this message by error, please advise us,
destroy it and refrain from communicating its contents to third parties. We
apologise for any inconvenience receiving this email improperly may cause
to you. Your personal data are included in a file owned by Avanzosc, S.L.
If you want to exercise your rights of access, correction, erasure and
objection you can contact the Controller at Julio Urkijo, 32, 20720,
Azkoitia (Gipuzkoa), T: 943 02 69 02 –
administracion@xxxxxxxxxxxx<soporte@xxxxxxxxxxxx>
*

JPEG image


Follow ups

References