← Back to team overview

openerp-community team mailing list archive

Re: Move the sale_exceptions module

 

Ok, thanks for the update, go for it !


On Mon, Nov 4, 2013 at 2:40 PM, sebastien beau
<sebastien.beau@xxxxxxxxxxxx>wrote:

> Hi as said in the MP, I think it's better to split this module 180 line
> can be in common and implementing the exception in a new module will be
> done in only 40 line of python.
> Note : I am totaly agree to merge your work without discuting of that, my
> aim was just to inform everyone about this change in order to avoid to move
> again this module later. If you think about having the generic module in
> server-env-tools and than the implementation in sale-wkfl purchase-wkfl...
> I am ok with that.
>
> Thanks
>
>
> 2013/11/4 Joël Grand-Guillaume <joel.grandguillaume@xxxxxxxxxxxxxx>
>
>> Hi,
>>
>> As Pedro said in the MP having such a general module doesn't seems
>> mandatory. The exception can IMO define in every module., that the solution
>> I suggest for now.
>>
>> Moreover, the sale_exception module was already there like this. So I
>> just moved it. We can't assume doing both in one. Your suggestion may break
>> back-compatibility so...
>>
>> My suggestion: move on to have it in the right project/branches with the
>> current MPI made, then when you'll be ready, make your own MP so we'll have
>> the opportunity to discuss that with something concrete !
>>
>> What do you think ?
>>
>> ++
>>
>> Joël
>>
>
>
>
> --
>
> BEAU Sébastien
> MagentoERPconnect Project Manager at Akretion
> twitter : seb_beau
> skype : sebastien_beau
> www.akretion.com
> http://launchpad.net/magentoerpconnect
>



-- 


*camptocamp*
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

*Joël Grand-Guillaume*
Division Manager
Business Solutions

+41 21 619 10 28
www.camptocamp.com

References