openerp-community team mailing list archive

[Sylvain LE GAL <sylvain.legal@xxxxxxxxx>]

HI,

In your exemple, there is a lot of modifications. 2 for bugs, 1 for
blueprint, etc...

Maybe if you propose one merge proposal for just one thing, your code will
be reviewed and merge faster. (specially for bugfix)

Otherwise, if you want to propose a lot of modifications, it's better to
propose an extra-addons in one of there repositories :
https://doc.openerp.com/contribute/05_developing_modules/#community-addons

My 2 cents.

regards.

*Sylvain LE GAL*

* Service informatiqueGroupement Régional Alimentaire de Proximité*
3 Grande rue des feuillants 69001 Lyon
*Bureau : *(+33) 09.72.32.33.17
*Astreinte :* (+33) 06.81.85.61.43
*Site Web** : *www.grap.coop
* Twitter : *@legalsylvain* <https://twitter.com/legalsylvain>*


2014-03-06 18:57 GMT+01:00 Sandy Carter <sandy.carter@xxxxxxxxxxxxxxxxxxxx>:

> Like, you most of my proposals to lp:~openerp are not reviewed and have
> not been despite months passing by and multiple emails.
>
> I absolutely say propose it to 7.0, trunk and OCB.
>
> The most feedback I get is from OCB reviews, which get dealt with or fixed
> and in turn increase the quality of my proposal to all three repos.
>
> It gets more eyes on your patch, better reviews and the hope is if it
> accepted into ocb and doesn't cause any problems, ~openerp will also take
> it.
>
> Just remember to link the same launchpad bug in the ocb MP and propose a
> patch to openerp as well.
>
> Le 2014-03-06 12:20, Lionel Sausin a écrit :
>
>  Dear community,
>> Like many, I made a few merge proposals for the official trunk, for
>> improvements that were never merged.
>> I'm not blaming anyone but I'd really like to share these improvements,
>> because :
>> 1/ I worked hard and they are mostly ready to be merged
>> and 2/ I could do with some help maintaining them
>> Still I'm unsure where to push some of my changes.
>>
>> One example :
>> https://code.launchpad.net/~numerigraphe/openobject-
>> addons/trunk-sale-order-dates/+merge/175249
>>
>> I did my home work and gathered all the community patches and pieces of
>> advice I could, and made a clean patch.
>> It does not change the database layout but it does add or change (minor)
>> features.
>>
>> Should I propose it for OCB-addons?
>> On the other hand I could probably refactor it into a module that I can
>> propose into the project "sale-wkfl". But that would certainly be a lot
>> of copy/paste from the original module - would it still have a chance to
>> be accepted?
>> Or should I simply resubmit my MP to the main trunk and pray (or pay?)
>> for someone to review it?
>>
>> Again, I'm not blaming, just looking for guidance.
>>
>> Lionel.
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~openerp-community
>> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~openerp-community
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to     : openerp-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openerp-community
> More help   : https://help.launchpad.net/ListHelp
>