openerp-community team mailing list archive

["Lionel Sausin, de la part de l'équipe informatique Numérigraphe" <informatique@xxxxxxxxxxxxxxxx>]

Dear Olivier,
Thanks for your care, the changes you made are fine by me. They're red 
on runbot at the moment but it seems to be a simple reference problem in 
the test.
If you merge them into the trunk, I'm confident I can port it all back 
to OCB v7.

Now, you're not proposing everyone with a stalled MP to email you 
personally, are you :) ?

Lionel.


Le 06/03/2014 21:45, Olivier Dony a écrit :
> On 03/06/2014 06:20 PM, Lionel Sausin wrote:
> > One example :
> > https://code.launchpad.net/~numerigraphe/openobject-addons/trunk-sale-order-dates/+merge/175249 
> >
> > I did my home work and gathered all the community patches and pieces of
> > advice I could, and made a clean patch.
>
> I remember reviewing it at the initial submission, I wonder why we 
> missed it during the pre-7.0 merges, perhaps it was still in WIP 
> status at that time?
>
> I've merged it in a test branch and cleaned up a few things. For 
> example _get_date_planned() was introduced by Akretion[1] after you 
> started working on your patch[2], and it is now part of the API. It 
> was also improved to deal with TZ issues when converting date -> 
> datetime. Apart from this I simplified a few lines, spellchecked and 
> removed things that are optional in trunk now, and removed the double 
> relativedelta/timedelta use as in your initial MP.
>
> Have a look at 
> lp:~openerp-dev/openobject-addons/trunk-order-dates-numerigraphe, if 
> it's green on runbot and you agree with my changes[3], then I'll merge 
> it.
>
> [1] rev 6077 
> http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/fp@xxxxxxxxxxx-20111220174007-gr3uqxntw8w13g2f#sale/sale.py
> [2] rev 5922
> [3] 
> http://bazaar.launchpad.net/~openerp-dev/openobject-addons/trunk-order-dates-numerigraphe/revision/9193