← Back to team overview

openerp-community team mailing list archive

Re: pull request reviews


Hi all,

Leonardo, thanks for bringing this topic to debate. This has been said
another times, that we must encourage people to review things, and I think
we are in the way, but dirty jobs like the ones we are doing now (migration
+ PEP8) it's very difficult to get them reviewed. In last spanish OpenERP
days (they were OpenERP yet ;) ), I convince a lot of people to start
contributing (you can see contributions or reviews from Avanzosc or
FactorLibre), but there's still a lot to do.

What Leonardo says can be a start. When we "stabilize" all the migration,
translations and so on, my next step will be to publish on Odoo Spain site
information in spanish on how to collaborate. I hope this serves to avoid
these problems.


2014-08-05 9:31 GMT+02:00 Leonardo Pistone <leonardo.pistone@xxxxxxxxxxxxxx>

> Hi all,
> after a discussion with Pedro, Sandy and Maxime on the pull request
> https://github.com/OCA/account-analytic/pull/2 , a general point came
> out: I always thought that anybody can do reviews, and then someone
> from the maintainer team can take the final decision to do the merge.
> The name "reviewer team" is misleading: the team cannot and should not
> make its code reviews alone. It just takes the final decision. I
> suggest adding a note to clarify that on
> https://pad.odoo.com/p/community-review .
> Joël, can you please confirm if that was the idea?
> On a sidenote, IMHO, while we should have rules, in cases like that I
> trust maintainers to bend rules from time to time a bit like Pedro
> did, (the reason  was to get the branch green ASAP, and we're only
> talking about linting). That should be the exception, not the rule, of
> course.
> If someone else disagrees, we can make another PR fast:
> https://github.com/OCA/account-analytic/pull/3 .
> Thanks!