← Back to team overview

openerp-india team mailing list archive

[Bug 1234004] [NEW] Manufacturing order created from procurement is automatically confirmed

 

Public bug reported:

I have a product with attributes:

- type of product: stockable
- procurement method: make to order
- supply method: produce

I have multiple locations where I can produce the product. For this
routings have been created.

When I confirm a Sale Order (SO), and run the scheduler, a Manufacturing
Order (MO) is created which is correct.

However the MO is immediately confirmed.

This makes it impossible to change:
- The scheduled date
- The bill of materials (I might have alternative BOM's)
- The routing (this is the problem I encountered)
- Locations for raw materials or finished products

I can understand that this works for simple setups, where each product
has only one possible routing, scheduled dates never change etc.

But there really has to be an option to have the MO created in draft
state. Just like Purchase Orders (PO) are created in draft state when
supply method is 'buy'.

Unfortunately this is not easy to change by creating an extra module, as
the confirmation is done right at the end of the function that creates
the MO at the first place.

It is the line in python file mrp/procurement.py, function make_mo:

wf_service.trg_validate(uid, 'mrp.production', produce_id,
'button_confirm', cr)

Calling this workflow should IMHO be dependent on a configuration option
wether to automatically confirm MO's or not.

There are to many use-cases where automatic confirmation is absolutely
undesirable.

Putting this change in  an extra module would requiring replacing the
whole make_mo function with a modified copy, which I think is a very bad
idea for maintainability.

** Affects: ocb-addons
     Importance: Undecided
         Status: New

** Affects: ocb-addons/7.0
     Importance: Undecided
         Status: New

** Affects: openobject-addons
     Importance: Undecided
         Status: New

** Description changed:

  I have a product with attributes:
  
  - type of product: stockable
  - procurement method: make to order
  - supply method: produce
  
  I have multiple locations where I can produce the product. For this
  routings have been created.
  
  When I confirm a Sale Order (SO), and run the scheduler, a Manufacturing
  Order (MO) is created which is correct.
  
  However the MO is immediately confirmed.
  
  This makes it impossible to change:
  - The scheduled date
  - The bill of materials (I might have alternative BOM's)
  - The routing (this is the problem I encountered)
  - Locations for raw materials or finished products
  
  I can understand that this works for simple setups, where each product
  has only one possible routing, scheduled dates never change etc.
  
  But there really has to be an option to have the MO created in draft
  state. Just like Purchase Orders (PO) are created in draft state when
  supply method is 'buy'.
  
  Unfortunately this is not easy to change by creating an extra module, as
- the conformation is done right at the end of the function that creates
+ the confirmation is done right at the end of the function that creates
  the MO at the first place.
  
  It is the line in python file mrp/procurement.py, function make_mo:
  
  wf_service.trg_validate(uid, 'mrp.production', produce_id,
  'button_confirm', cr)
  
  Calling this workflow should IMHO be dependent on a configuration option
  wether to automatically confirm MO's or not.
  
  There are to many use-cases where automatic confirmation is absolutely
  undesirable.
  
  Putting this change in  an extra module would requiring replacing the
  whole make_mo function with a modified copy, which I think is a very bad
  idea for maintainability.

** Also affects: ocb-addons
   Importance: Undecided
       Status: New

** Also affects: ocb-addons/7.0
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1234004

Title:
  Manufacturing order created from procurement is automatically
  confirmed

Status in OpenERP Community Backports (Addons):
  New
Status in OpenERP Community Backports (Addons) 7.0 series:
  New
Status in OpenERP Addons (modules):
  New

Bug description:
  I have a product with attributes:

  - type of product: stockable
  - procurement method: make to order
  - supply method: produce

  I have multiple locations where I can produce the product. For this
  routings have been created.

  When I confirm a Sale Order (SO), and run the scheduler, a
  Manufacturing Order (MO) is created which is correct.

  However the MO is immediately confirmed.

  This makes it impossible to change:
  - The scheduled date
  - The bill of materials (I might have alternative BOM's)
  - The routing (this is the problem I encountered)
  - Locations for raw materials or finished products

  I can understand that this works for simple setups, where each product
  has only one possible routing, scheduled dates never change etc.

  But there really has to be an option to have the MO created in draft
  state. Just like Purchase Orders (PO) are created in draft state when
  supply method is 'buy'.

  Unfortunately this is not easy to change by creating an extra module,
  as the confirmation is done right at the end of the function that
  creates the MO at the first place.

  It is the line in python file mrp/procurement.py, function make_mo:

  wf_service.trg_validate(uid, 'mrp.production', produce_id,
  'button_confirm', cr)

  Calling this workflow should IMHO be dependent on a configuration
  option wether to automatically confirm MO's or not.

  There are to many use-cases where automatic confirmation is absolutely
  undesirable.

  Putting this change in  an extra module would requiring replacing the
  whole make_mo function with a modified copy, which I think is a very
  bad idea for maintainability.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1234004/+subscriptions


Follow ups

References