openerp-india team mailing list archive

["Andrius Preimantas @ hbee" <andrius.preimantas@xxxxxxxxx>]

Public bug reported:

Addons revno: 9789

Reproduction:
1. Create Manufacturing Order in draft state
2. In the page Scheduled Products click button Compute Data
3. Click on any of the recently computed line and change desired value (say quantity)
4. Save MO and observe that the changed value persists
5. Confirm an order and observe that changed value is reset to the value from BOM
6. Stock Moves in Products to Consume list also holds these reset values, not the changed ones from step #3

Expected behaviour:
When confirming MO the system should create Stock Moves from lines in Scheduled Products page, without implicitly resetting then to the BOM's values.

Investigation:
It turns out the method test_if_product() was modified with this revision: 
http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9445
IMHO prior to this revision the method was already broken, but at least it did not implicitly reset the Scheduled Lines. After this revision the lines are modified. So there 2 wrong things with that:
1. Why do method named "test_if_product" also implicitly modifies data (name suggest it should just check something without leaving any impact)
2. I assume you are intentionally resetting those lines, which IMHO shouldn't happen. If you do that, at least mark Scheduled Products as readonly, so that users wouldn't be confused after altering expected MO composition and later getting different composition...

Cheers,
Andrius

** Affects: openobject-addons
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of OpenERP
Indian Team, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/1274026

Title:
  [7.0] Manufacturing Order forces scheduled products recomputation

Status in OpenERP Addons (modules):
  New

Bug description:
  Addons revno: 9789

  Reproduction:
  1. Create Manufacturing Order in draft state
  2. In the page Scheduled Products click button Compute Data
  3. Click on any of the recently computed line and change desired value (say quantity)
  4. Save MO and observe that the changed value persists
  5. Confirm an order and observe that changed value is reset to the value from BOM
  6. Stock Moves in Products to Consume list also holds these reset values, not the changed ones from step #3

  Expected behaviour:
  When confirming MO the system should create Stock Moves from lines in Scheduled Products page, without implicitly resetting then to the BOM's values.

  Investigation:
  It turns out the method test_if_product() was modified with this revision: 
  http://bazaar.launchpad.net/~openerp/openobject-addons/7.0/revision/9445
  IMHO prior to this revision the method was already broken, but at least it did not implicitly reset the Scheduled Lines. After this revision the lines are modified. So there 2 wrong things with that:
  1. Why do method named "test_if_product" also implicitly modifies data (name suggest it should just check something without leaving any impact)
  2. I assume you are intentionally resetting those lines, which IMHO shouldn't happen. If you do that, at least mark Scheduled Products as readonly, so that users wouldn't be confused after altering expected MO composition and later getting different composition...

  Cheers,
  Andrius

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/1274026/+subscriptions