← Back to team overview

openjdk team mailing list archive

Bug#944738: Bug#944738: jlink: Hash of module differs to expected hash recorded in java.base

 

On Thu, Sep 24, 2020 at 05:21:46PM -0700, tony mancill wrote:
> On Thu, Sep 24, 2020 at 10:52:50AM +0100, Julian Gilbey wrote:
> > Great, and there's a bug report #944738
> > (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944738) for
> > openjdk-11; I haven't checked if there are bugs reported against the
> > other two versions.
> 
> I'm not able to reproduce the problem with openjdk-15.  Perhaps the
> non-determinism has already been addressed upstream?

Oh, interesting.  So the non-determinism problem still exists, and
java.base.jmod contains non-deterministic SHA-256 hashes.  But jlink
seems to no longer check whether the hashes match, so the jlink tests
now work.  This does seem to be to be a poor resolution to the
(Debian) bug!  No idea why they've done this, though.

So I suggest that we still use the patch with openjdk-15 to avoid
introducing non-determinism into the build, but this is clearly less
important than on 11 and 14.

> openjdk-13 does have the problem, so we could do another upload, but
> given that it's not an LTS release and 14 is already available and
> patched, do we need to?

Good question.  It's easy to do, and it does fix a bug, so I don't see
a good reason not to do so.

> Neither 13 nor 15 have open bugs filed against them for the jlink hash
> issue.

Indeed, but we can still fix it (and in the changelog say something
like "fixes bug #... for this version of openjdk").

Best wishes,

   Julian


Follow ups

References