← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~phill-ridout/openlp/1065420 into lp:openlp

 

> Unless you're using self.is_valid elsewhere in the code, that attribute has no
> reason to exist and is just using up extra memory. As for "but we might use it
> later on", I call YAGNI (Ya Ain't Gonna Need It). Add it when you need it.

self.is_valid is used elsewhere.

Speaking with Tim, he has plans to expand this in 2.0, so it should be left as is.
-- 
https://code.launchpad.net/~phill-ridout/openlp/1065420/+merge/132735
Your team OpenLP Core is subscribed to branch lp:openlp.


References