← Back to team overview

openstack team mailing list archive

Re: Should we remove nova-combined ?


On Mon, Feb 21, 2011 at 8:49 AM, Thierry Carrez <thierry@xxxxxxxxxxxxx>wrote:

> Hi everyone,
> The bin/nova-combined script duplicates code and functionality found
> elsewhere, which is very error-prone. The quantity of duplicated code
> grew with nova-api switch to paste. It seems to cover one very specific
> use case (someone that runs from branch/tarball and wants to run
> nova-{compute,network,volume,scheduler,api} but not nova-objectstore on
> a single host).
The reason it was added was to aid in local development and testing, but it
was only ever added as a demonstration because with objectstore still around
it couldn't run the full stack in the same way.

I still think it is a useful idea but there is no need to keep it around
right now.

> I'd like to get rid of it before I add more code to nova-api that will
> need to be duplicated to nova-combined. Someone needing it could easily
> replace it with a simple script that calls the other binaries, or by
> nova.sh...

The functionality isn't actually easily duplicated by calling the other
binaries, the point of it was a single foreground process to start and stop
easily and quickly while debugging so that one doesn't have to check
multiple log files, multiple pidfiles or multiple process states while doing
a frequent 'try command, change code, reload' loop to find bugs. It also
simplifies some uses of pdb.

> That said, I guess it was originally added for a reason, so if you care
> about it, please shout !
Anyway, as mentioned, it isn't being used by anybody currently and is easy
enough to re-add once its usefulness is more applicable to people's

> --
> Thierry Carrez (ttx)
> Release Manager, OpenStack
> _______________________________________________
> Mailing list: https://launchpad.net/~openstack
> Post to     : openstack@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~openstack
> More help   : https://help.launchpad.net/ListHelp