openstack team mailing list archive
-
openstack team
-
Mailing list archive
-
Message #14409
Don't bypass code-review.
I've had code reviews sitting out for over a week, looking to fix issues with the ZeroMQ driver in openstack-common. I'd love to get it fixed, and nudged a couple of people to get the reviews in, but figured that it would get in eventually - and if not, I'd prod harder, or perhaps someone else that would want to see these problems fixed, would help review. Instead...
Today, I had someone ignore my reviews in progress, push his own review, and even APPROVED his own review.
What the hell?
Review in question:
https://review.openstack.org/#/c/9594/
(My) Reviews in progress:
https://review.openstack.org/#/q/status:open+project:openstack/openstack-common+branch:master+topic:bug/1021459,n,z
--
Eric Windisch
Follow ups
References