← Back to team overview

phatch-dev team mailing list archive

Re: Varborder wierdness

 

Hi Erich,

Nice work :)
Would you provide a show case for the bug (an action list and a sample
image)? I'm unable to produce the artifacts you are describing. It is
working fine for me. And the result is nice!

Do we need to support negative border values? There is already a crop action
that supports different crop values for top, left, bottom and right.
One more thing there is a syntax error in the code committed by Stani.
  File "/home/nadia/projects/phatch/phatch/actions/varborder.py", line 29
    if im
        ^
SyntaxError: invalid syntax

Keep up the nice work :)

Best Regards,
Nadia

On Mon, Jun 8, 2009 at 10:49 PM, Erich Heine <sophacles@xxxxxxxxx> wrote:

> Hi all,
> So I've been working to get this variable border action working.  Right the
> border function (in the action) mostly works. It does positive and negative
> borders, as described in the blueprint. The wierd thing is that when i
> create an image that has a positive border, there are artifacts in the
> positive border area, near the orignial image. These artifacts are just
> slightly discoloured lines running parallel to the original image borders.
>
> Can you guys help tell me figure out what the problem is? (My latest code
> is pushed to my launchpad branch).
>
> Regards,
> Erich
>
> _______________________________________________
> Mailing list: https://launchpad.net/~phatch-dev<https://launchpad.net/%7Ephatch-dev>
> Post to     : phatch-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~phatch-dev<https://launchpad.net/%7Ephatch-dev>
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References