← Back to team overview

qpdfview team mailing list archive

Re: Request for testing after extensive refactoring

 

Am 23.03.2012, 09:19 Uhr, schrieb bdjnk <bdjnks@xxxxxxxxx>:

Hey Adam.

On 03/22/2012 08:27 PM, Adam Reichold wrote:
This is again the "problem" of manual control over the start of a new search and should be gone. When the search term is edited, the current search is invalidated and a new one started. The same when the search bar is closed or the tab is changed. This also brings back the notorious search timer. Again you can burn your CPU if you type really slowing, but it should not hand the program. (And 1 second should be enough to type more than two letters. Or should this be increased? Thinking of some older people...) You can also force the timeout by pressing return.
Because of the ability to force a timeout, I would think that extending that timer is okay. I know that I sometimes pause to think for a second in the middle of doing random things, like entering a search term. Of course adding letters just restarts the search with the new term, but there's a delay and it's a little jarring.

Ok, I increased the timer to two seconds.

Any help and time spent is very much appreciated. It is really getting hard to find all the corner cases as the complexity of the UI increases. Especially the tabs seem to make things difficult. :-) What would probably help at this point is testing of the things besides search. I didn't really change any functionality, but with all the changes made. Who knows malicious error I made that will result in "format C:" being executed. Wait, that was another time...
The only possible issue I've noticed, after quite a lot of messing about, is that new page takes you to the middle of the next page in one or two column mode when zoomed so the height of a page is greater than the document display area. Maybe it should take you to the top of the next page instead.

Ok, I changed that. There seems to be a slight inconsistency in how QGraphicsView::ensureVisible works, so that you don't get exactly the same result when skipping forwards as when skipping backwards. Don't know if this is a problem.

Aside from that, I haven't found anything problematic. It seems to me like you can move forward with new features (or something tedious, like code commenting).

I will probably not add a new feature if next release is to have version number 0.2.1 but rather spend some time to improve the maintainability of the code. This will hopefully also make contributions by other people easier. Also, before pressing, I'd like to improve the Debian packaging so that our potential user base is larger. The Debian packages I currently put on Launchpad are stopgap measures and are seldomly used. Benjamin Eltzner is looking to get a Debian package actually into Debian becoming its maintainer but this process will take a lot of time to finish. So maybe I talk him into a PPA before that or try to create one myself. Maybe make the Debian files part of the source code...

I would also like to get some of Leo's translations released rather sooner than later.

Have a great day, Michael.

You too!

P.S. As a side remark, try to send replies to the mailing list address qpdfview@xxxxxxxxxxxxxxxxxxx. This ensures that everyone can participate and makes managing the mail in tagging mail programs easier. Thanks.


References