rohc team mailing list archive

[Didier Barvaux <didier@xxxxxxxxxxx>]

Hi Idilio,

As a foreword, please note that I forwarded your email to the project's
mailing list. This is the place to discuss about the ROHC library.
You'll be able to send email to the list after you subscribed :
http://launchpad.net/~rohc/+join

Now, back to the problem you reported :)

You're right about the problem, the ROHC library crashes with the sample
capture you sent me. Thank you for the report!

The TCP profile handles unknown TCP option in a different manner than
other options. The code that handles those unknown options was wrong. I
fixed it. I added a non-regression test to avoid the problem to come
back later.


It made me think about 2 other cases:
 * 8 or more different TCP options,
 * 40 1-byte TCP options.

The 2 cases caused compression or decompression failures. I fixed them
too. I added two non-regression tests to avoid the problem to come back
later.


If you want to test with the fixes, you may try the main branch at
revision 1082 or later.

Regards,
Didier


----- Message Transféré -----

Date: Fri, 25 Apr 2014 17:13:41 +0200
De: Idilio Drago <idilio.drago@xxxxxxxxx>
À: didier@xxxxxxxxxxx
Sujet: Possible bug in lp:rohc branch


Hi Didier, 

While playing with your rohc code currently under development, I ran
into a segfault in the TCP profile:

==24301== Invalid write of size 1
==24301==    at 0x5080A71: tcp_code_dynamic_tcp_part (c_tcp.c:3051)
==24301==    by 0x50A0E41: c_tcp_encode (c_tcp.c:1879)
==24301==    by 0x508478B: rohc_compress3 (rohc_comp.c:968)


In case you were not yet aware of it yet, the packet in the attached
pcap triggers it.

Thanks for the nice work to maintain this library. 

Idilio

Attachment: sample.pcap
Description: application/vnd.tcpdump.pcap

Attachment: signature.asc
Description: PGP signature