touch-packages team mailing list archive

[Roman Odaisky <1406133@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The libsmartcols component used by findmnt to draw the filesystem tree
is smart enough to wrap lines in case the output doesn’t fit into the
screen. However, it fails to draw the lines correctly in this case.
Attached patch fixes the problem. Someone more knowledgeable in
libsmartcols internals might want to change the buffer size from an
arbitrary 1024 to something taken from actual data, the best way to do
that eludes me.

Sample of incorrect output:

--%<----
├─/boot                      /dev/sda1          ext3            rw,relatime,data=ordered
├─/usr                       /dev/mapper/vgshadow-ubuntu_usr
                                                ext4            rw,noatime,data=ordered
├─/var                       /dev/mapper/vgshadow-ubuntu_var
                                                ext4            rw,noatime,data=ordered
├─/home                      /dev/mapper/vgshadow-home
                                                ext4            rw,noatime,data=ordered
└─/srv                       /dev/mapper/vgshadow-srv
                                                reiserfs        rw,noatime,notail
--%<----

Patch adds missing vertical lines at any level necessary.

** Affects: util-linux (Ubuntu)
     Importance: Undecided
         Status: New

** Patch added: "libsmartcols-art-fix.diff"
   https://bugs.launchpad.net/bugs/1406133/+attachment/4288863/+files/libsmartcols-art-fix.diff

-- 
You received this bug notification because you are a member of Ubuntu
Touch seeded packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1406133

Title:
  findmnt: libsmartcols ASCII art problem [patch]

Status in util-linux package in Ubuntu:
  New

Bug description:
  The libsmartcols component used by findmnt to draw the filesystem tree
  is smart enough to wrap lines in case the output doesn’t fit into the
  screen. However, it fails to draw the lines correctly in this case.
  Attached patch fixes the problem. Someone more knowledgeable in
  libsmartcols internals might want to change the buffer size from an
  arbitrary 1024 to something taken from actual data, the best way to do
  that eludes me.

  Sample of incorrect output:

  --%<----
  ├─/boot                      /dev/sda1          ext3            rw,relatime,data=ordered
  ├─/usr                       /dev/mapper/vgshadow-ubuntu_usr
                                                  ext4            rw,noatime,data=ordered
  ├─/var                       /dev/mapper/vgshadow-ubuntu_var
                                                  ext4            rw,noatime,data=ordered
  ├─/home                      /dev/mapper/vgshadow-home
                                                  ext4            rw,noatime,data=ordered
  └─/srv                       /dev/mapper/vgshadow-srv
                                                  reiserfs        rw,noatime,notail
  --%<----

  Patch adds missing vertical lines at any level necessary.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1406133/+subscriptions