ubuntu-accomplishments-contributors team mailing list archive

[Denis Darii <dnxdevel@xxxxxxxxx>]

Ok Janos, I'll wait your review and merge in order to go ahead with another
changes.

On 15 March 2012 13:46, Janos Gyerik <info@xxxxxxxxxxx> wrote:

> Thanks a lot Darii, will do tonight (UTC+1 timezone)
>
> Janos
>
> On Thu, Mar 15, 2012 at 1:17 PM, Denis Darii <dnxdevel@xxxxxxxxx> wrote:
> > Thank you Janos!
> >
> > I created a merge request and indicate you as a reviewer.
> > The only change that doesn't correspond to my request description is the
> > commit about the django.conf.settings, I think.
> >
> >
> > On 15 March 2012 12:41, Janos Gyerik <info@xxxxxxxxxxx> wrote:
> >>
> >> Hi Darii,
> >>
> >> > As PEP8 says "Never mix tabs and spaces." and "spaces-only are
> strongly
> >> > recommended over tabs" here http://www.python.org/dev/peps/pep-0008
> >> > /#tabs-or-spaces , may I gently ask you yo use 4 spaces per
> indentation
> >> > level?
> >> >
> >> > I already fixed some of this inconvenince in my web-editor branch.
> >>
> >> I totally agree! Can you please fix them all everywhere? And if
> >> possible put the indent fix in its own commit, without mixing other
> >> meaningful changes (for easier diff review).
> >>
> >> Thanks!
> >> Janos
> >> --
> >> Janos Gyerik
> >> http://titan2x.com/
> >
> >
> >
> >
> > --
> > I'm using Linux because i'm freedom dependent.
> >
>
>
>
> --
> Janos Gyerik
> http://titan2x.com/
>



-- 
I'm using Linux because i'm freedom dependent.