← Back to team overview

ubuntu-accomplishments-contributors team mailing list archive

get_trophy_data return value

 

get_trophy_data() has no return value for the case where the accomplishment is not yet completed, so I think it defaults to None. Should it be returning an empty dictionary instead? At a minimum, I'd like to explicitly return None in that code. (I can whichever as part of some other test changes that I'm working on).

Opinions?


Follow ups