← Back to team overview

ubuntu-appstore-developers team mailing list archive

Re: Tracking overrides in the review scripts

 

On 09/17/2014 08:44 AM, Jamie Strandboge wrote:

Meh, typos and omissions:

>   "com.ubuntu.music":
>   {
>     "reviewer": "popey",
>     "date": "2014-09-07",
>     "note": "Unconfined ok per jdstrand, but should move to confined with
> music-files-read policy group in the future",

This should have included:
     "vendor": "Ubuntu",

>     "overrides": {
>       "error": {
>         "security_template_valid (apparmor.json)":
>           "(MANUAL REVIEW) 'unconfined' not allowed"
>       },
>       "warn": {
>         "lint_click_local_extensions":
>           "found unofficial extensions: x-source, x-test"
>         }
>       }
>     }
>   },

...

>   "com.ubuntu.developer.foo.bar":
>   {
>     "reviewer": "jdstrand",
>     "date": "2014-09-07",
>     "note": "Uses global contacts list in read only. Code review shown to abuse
> access. New code should be verified this is still true.",
>     "requires_new_review": true,

This should have said "Code review shown not to abuse access."

>     "overrides": {
>       "error": {
>         "security_policy_groups_safe_contacts (apparmor.json)":
>           "(MANUAL REVIEW) reserved policy group 'contacts': vetted applications
> only"
>       },
>       "warn": {}
>     }
>   }
> }


-- 
Jamie Strandboge                 http://www.ubuntu.com/

Attachment: signature.asc
Description: OpenPGP digital signature


References