← Back to team overview

ubuntu-phone team mailing list archive

Re: LP: #1260712 post-mortem and improving our processes

 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Dec 17, 2013, at 02:25 PM, Alberto Mardegan wrote:

>In fact, it was not necessary: the ApplyUpdate() could have stayed as it was,
>and yet be processed asynchronously, allowing the main loop to continue
>running.  I'm not sure if that's possible to do with the python "dbus"
>module, but it certainly is with python + Gio (via GLib introspection).

Not only possible, but trivial!  In fact, that's what Didier's patch
implements:

http://tinyurl.com/n5shrfy

The problem is that it's also kind of useless!  The async version of the
method can only return a hardcoded string, so the "no error" empty string is
used.  But what if there is an error applying the update?  The async version
can only report that via signal, thus the new Rebooting signal.

The current Rebooting signal still isn't useful enough, so in further
discussions with Didier, we're going to make it more useful for the ui:

https://bugs.launchpad.net/ubuntu-system-image/+bug/1260768

And yes, we'll make sure to do a better job of coordinated API changes
this time. ;)

- -Barry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQIcBAEBCAAGBQJSsdW1AAoJEBJutWOnSwa/kw8QAJd1Q59YXsjMt3t+zJMPb2Jn
XV+qH1WvMtEtmMwB3iIymdx+6lGAXyIvzCob6yQPhWIpyJvtSKzLDITedZeqKL/B
bQ+aubahldY2PS4N7jkKGR4zVAX1UA+LOxCGunX0xaq6lB5MTMJv+YPeMzh5Q9O6
WWAjLTSPSo9P4kXklxh6rBjbk+BiBFQgS5u3OHM8ahOM1H139nfXuMqtXCfK3Vsc
IfhCN2rcUP/BommoRIlayxp/3abg3DP9MZE0PnG3sG98JF413Kz9FeXP59Sx/wIp
qzVI4xvZ6RorUFX+G0QlJUDA+o/IyepyNMd2cjbgS5vRsUjrJCzCfmXimWygkX53
bQM9plMHR/e37zG/5+VDVsngQwc4rQzTJY+AzloAdwqV0LpsUxpy/WssEei0PkWq
oGS4pCtqWC2Ezdu2pGst+VGwn7MDUlbl3LY2+LbpVWLPLQWScO+JjfEO8W/Wyv6W
JIiobQkKisFfavssnzaiSwegsPb2uprk5CerSef9XNYpajWJ0rb1AGHpEtcNGYMP
dAZVk6jJla6dNYSm2i9ocXe0wGqgWEPXlVsK7t5a4FB6LhOR0HAukZqpcPU00Kc/
qX9SXugSpcLEnfZshHp8AUquIahlaOTwab5TGvx6TW3b4tFpU5ucjG6303uxehT2
3e1nnIhfG/4koYVFnb57
=RCCu
-----END PGP SIGNATURE-----

Follow ups

References