← Back to team overview

ubuntu-phone team mailing list archive

Ubuntu phone calendar app

 

Am Montag, 23. November 2015 schrieb Renato Filho :
> In fact this command looks redundant:

It is, so I had already proposed an MP for that, which Mihir merged
quickly. ;)

> text: i18n.tr(currentMonth.toLocaleString(Qt.locale(),i18n.tr("MMMM
yyyy")))
>
> you do not need the extra: i18n.tr(....) covering the result of
> 'currentMonth.toLocaleString(Qt.locale(),i18n.tr("MMMM yyyy"))'
>
> besides that everything looks good. I did some tests on my device and
> I did not find any problem, it printed the correct month name in Pt
> BR.
>
> You can check if you system is using the correct languange by trying
> this command on your terminal: date +%B, it should print the full
> month name in your language.
>
>
> BR
> Renato
>
>
>
>
>
>
> On Fri, Nov 20, 2015 at 7:29 PM, Niklas Wenzel
> <nikwen.developer@xxxxxxxxx> wrote:
>> Hi all,
>>
>> I just checked the code and found the following line which is responsible
>> for setting the title of the month view (MonthView.qml):
>>
>>> text: i18n.tr(currentMonth.toLocaleString(Qt.locale(),i18n.tr("MMMM
>>> yyyy")))
>>
>>
>> This means that the calendar app uses Qt's mechanisms for formatting the
>> month. What it passes is only the user's locale and a format string
telling
>> Qt to put the long month name before the four-digit representation of the
>> year.
>> Therefore, I'd say that this needs to be fixed in Qt itself. Please go
ahead
>> and either fix the bug yourself or report it so that someone else can fix
>> it.
>>
>> Cheers,
>> Niklas
>>
>> 2015-11-20 13:43 GMT+01:00 Dominik Wnęk <dominik@xxxxxxxx>:
>>>
>>> I'm sure these are system-wide. There will be a single string for every
>>> month, even though we actually need 2 in Polish. If you look at the
Today
>>> scope, it says 20 Listopada today - which is the correct form, even if
it
>>> probably shouldn't be capitalised. The same string is probably used in
the
>>> calendar.
>>>
>>> UT is not the only culprit here, either, as I've seen months named
>>> "Listopada" in the iOS calendar as well (this has since been corrected I
>>> believe).
>>>
>>> I agree seeing 20 listopad is less jarring than having months named
>>> "listopada" in the calendar, but I think you'll just be fixing one
thing and
>>> breaking another.
>>>
>>> For non-Polish speakers: Listopad is the name of the month November,
>>> whereas the form "listopada" basically means "of November", as in "the
20th
>>> of November".
>>>
>>> Dominik
>>>
>>> W piątek, 20 listopada 2015 12:41:22 CET, Krzysztof Tataradziński
>>> napisałeś:
>>>>
>>>> Hello,
>>>>
>>>> where I can find strings responsible for name of month in that app
>>>> (https://launchpad.net/ubuntu-calendar-app ) - and no, in that app
>>>> there aren't any month-name related strings.
>>>> I'm asking because we must correct them. In Polish we see 'Stycznia'
>>>> insted of 'Styczeń' in month view.
>>>>
>>>> Best regards,
>>>> Krzysztof Tataradziński
>>>> https://launchpad.net/~ktatar156
>>>>
>>>
>>> --
>>> Sent using Dekko from my Ubuntu device
>>>
>>>
>>> --
>>> Mailing list: https://launchpad.net/~ubuntu-phone
>>> Post to     : ubuntu-phone@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~ubuntu-phone
>>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>> --
>> Mailing list: https://launchpad.net/~ubuntu-phone
>> Post to     : ubuntu-phone@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~ubuntu-phone
>> More help   : https://help.launchpad.net/ListHelp
>>
>

References