ubuntu-touch-coreapps-reviewers team mailing list archive

[Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>]

Review: Needs Fixing

Hi Victor.

We could stick with GLOB then, for now.
But we don't want to put js and qml files in the main directory (it is /app directory for that).
According to your description, your intention was to add README* files.

To make it perfectly fine it will be great to change it to:

file(GLOB README_FILES
     RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
     README*)

the glob for js and qml files should be inside "/app/CMakeLists.txt".


By the way if you really want to include all js and qml files, you should use RECURSE. Without that it doesn't have sense to include js and qml files as wildcat.


-- 
https://code.launchpad.net/~vthompson/ubuntu-clock-app/clock-show-all-READMEs/+merge/267439
Your team Ubuntu Clock Developers is subscribed to branch lp:ubuntu-clock-app.