← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~vthompson/music-app/fix-1511585-part-1 into lp:music-app

 

Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1511585-part-1 into lp:music-app.

Commit message:
* Update canned mediastore.db schema version.

Requested reviews:
  Music App Developers (music-app-dev)

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1511585-part-1/+merge/276207

* Update canned mediastore.db schema version.

With this change the app will load, however, it appears as though individual tracks/listitems are not showing up in trunk. The CardViews are working, but individual tracks are now showing up.

At the moment I can only test on the desktop, testing against the device has caused by my devices to need reflashing.

This is what I now see when running test_shuffle, for instance:

Traceback (most recent call last):
  File "/home/victor/Development/music-app/tests/autopilot/music_app/tests/test_music.py", line 242, in test_shuffle
    self.app.populate_queue()  # populate queue
  File "/home/victor/Development/music-app/tests/autopilot/music_app/__init__.py", line 126, in populate_queue
    track = tracksPage.get_track(0)
  File "/home/victor/Development/music-app/tests/autopilot/music_app/__init__.py", line 201, in get_track
    objectName="tracksPageListItem" + str(i)))
  File "/usr/lib/python3/dist-packages/autopilot/introspection/dbus.py", line 295, in wait_select_single
    return self.select_single(type_name, **kwargs)
  File "/usr/lib/python3/dist-packages/autopilot/introspection/dbus.py", line 244, in select_single
    raise StateNotFoundError(type_name_str, **kwargs)
autopilot.exceptions.StateNotFoundError: Object not found with name 'MusicListItem' and properties {'objectName': 'tracksPageListItem0'}.

-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-1511585-part-1 into lp:music-app.
=== modified file 'debian/changelog'
--- debian/changelog	2015-09-25 08:11:22 +0000
+++ debian/changelog	2015-10-30 02:35:43 +0000
@@ -5,6 +5,7 @@
 
   [ Victor Thompson ]
   * Remove some deprecated code for the UbuntuShape image property.
+  * Update canned mediastore.db schema version from 8 to 9.
 
  -- Bartosz Kosiorek <gang65@xxxxxxxxxxxxxx>  Tue, 08 Sep 2015 10:08:49 +0200
 

=== modified file 'tests/autopilot/music_app/content/mediascanner-2.0/mediastore.db'
Binary files tests/autopilot/music_app/content/mediascanner-2.0/mediastore.db	2014-09-04 05:21:54 +0000 and tests/autopilot/music_app/content/mediascanner-2.0/mediastore.db	2015-10-30 02:35:43 +0000 differ

Follow ups