ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

The proposal to merge lp:~vthompson/music-app/fix-1515067 into lp:music-app has been updated.

Description changed to:

* Remove repeater for getting album titles in Artists.qml

This makes the artistart queries the following: image://artistart/artist=Atmosphere&album=

There are 2 main issues/questions concerning this change:
1. Is there a benefit to providing the "album" in this query? Ie, will we get better results?
2. When I remove the album parameter, such that the query is "image://artistart/artist=Atmosphere", none of the artist thumbnails work. This seems to suggest to me that providing an album would be desired.

That being said, the results for providing a blank album seem to be the same as before--just fewer queries.

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1515067/+merge/277306
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-1515067 into lp:music-app.