ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/fix-1515067 into lp:music-app.

Commit message:
* Remove repeater for getting album titles in Artists.qml

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1515067 in Ubuntu Music App: "Redunt requests for artist art"
  https://bugs.launchpad.net/music-app/+bug/1515067

For more details, see:
https://code.launchpad.net/~vthompson/music-app/fix-1515067/+merge/277306

* Remove repeater for getting album titles in Artists.qml

This makes the artistart queries the following: image://artistart/artist=Atmosphere&album=

There are 2 main issues with this:
1. Is there a benefit to providing the "album" in this query? Ie, will we get better results?
2. When I remove the album parameter, such that the query is "image://artistart/artist=Atmosphere", none of the artist thumbnails work. This seems to suggest to me that providing an album would be desired.

That being said, the results for providing a blank album seem to be the same as before--just fewer queries.
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/fix-1515067 into lp:music-app.

=== modified file 'app/ui/Artists.qml'
--- app/ui/Artists.qml	2015-10-28 01:05:33 +0000
+++ app/ui/Artists.qml	2015-11-12 03:19:59 +0000
@@ -73,31 +73,11 @@
         }
         delegate: Card {
             id: artistCard
-            coverSources: [{art: "image://artistart/artist=" + model.artist + "&album=" + artistCard.album}]
+            coverSources: [{art: "image://artistart/artist=" + model.artist + "&album="}]
             objectName: "artistsPageGridItem" + index
             primaryText: model.artist != "" ? model.artist : i18n.tr("Unknown Artist")
             secondaryTextVisible: false
 
-            property string album: ""
-
-            AlbumsModel {
-                id: albumArtistModel
-                albumArtist: model.artist
-                store: musicStore
-            }
-
-            Repeater {
-                id: albumArtistModelRepeater
-                model: albumArtistModel
-                delegate: Item {
-                    property string album: model.title
-                }
-
-                onItemAdded: {
-                    artistCard.album = item.album
-                }
-            }
-
             onClicked: {
                 mainPageStack.push(Qt.resolvedUrl("ArtistView.qml"),
                                    {

=== modified file 'debian/changelog'
--- debian/changelog	2015-11-03 02:44:19 +0000
+++ debian/changelog	2015-11-12 03:19:59 +0000
@@ -9,6 +9,7 @@
   * Update canned mediastore.db schema version from 8 to 9 (LP: #1511585).
   * Update canned mediastore.db schema version from 9 to 10.
   * Add directions for updating and debugging schema version changes.
+  * Remove repeater for getting album titles in Artists.qml (LP: #1515067).
 
   [ Andrew Hayzen ]
   * Switch to using the new uc1.3 listitems within the SDK