ubuntu-translations-coordinators team mailing list archive

[Gabor Kelemen <kelemeng@xxxxxxxx>]

Public bug reported:

Currently the pot file generation is broken: the po/Makefile is lacking a top_srcdir variable, which makes running intltool-update fail. Therefore, the call to execute cd po && make update-po it is commented out in setup.py. 
But wait, if it already uses python-distutils, why not just use its built-in i18n handling facilities, instead of this custom Makefile?

I'm attaching a branch that makes life simpler by replacing po/Makefile
with the build_i18n function from python-distutils-extra, then updates
the POTFILES.in and the pot file itself.

Side note: this was circumvented in bug #549106 on the Ubuntu level, but
only there, and only until the latest rewrite of debian/rules[1]. I hope
this solution is going to be more futureproof :).

[1]: http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/precise
/command-not-found/precise/revision/84#debian/rules

** Affects: command-not-found
     Importance: Undecided
         Status: New

** Affects: ubuntu-translations
     Importance: High
     Assignee: Gabor Kelemen (kelemeng)
         Status: Triaged


** Tags: needs-pot-on-build

** Also affects: ubuntu-translations
   Importance: Undecided
       Status: New

** Changed in: ubuntu-translations
       Status: New => Triaged

** Changed in: ubuntu-translations
   Importance: Undecided => High

** Changed in: ubuntu-translations
     Assignee: (unassigned) => Gabor Kelemen (kelemeng)

** Branch linked: lp:~kelemeng/command-not-found/bug1007502

** Tags added: needs-pot-on-build

-- 
You received this bug notification because you are a member of Ubuntu
Translations Coordinators, which is subscribed to Ubuntu Translations.
Matching subscriptions: Ubuntu Translations bug mail
https://bugs.launchpad.net/bugs/1007502

Title:
  Make pot file generation work again in c-n-f

Status in command-not-found handler:
  New
Status in Ubuntu Translations:
  Triaged

Bug description:
  Currently the pot file generation is broken: the po/Makefile is lacking a top_srcdir variable, which makes running intltool-update fail. Therefore, the call to execute cd po && make update-po it is commented out in setup.py. 
  But wait, if it already uses python-distutils, why not just use its built-in i18n handling facilities, instead of this custom Makefile?

  I'm attaching a branch that makes life simpler by replacing
  po/Makefile with the build_i18n function from python-distutils-extra,
  then updates the POTFILES.in and the pot file itself.

  Side note: this was circumvented in bug #549106 on the Ubuntu level,
  but only there, and only until the latest rewrite of debian/rules[1].
  I hope this solution is going to be more futureproof :).

  [1]: http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/precise
  /command-not-found/precise/revision/84#debian/rules

To manage notifications about this bug go to:
https://bugs.launchpad.net/command-not-found/+bug/1007502/+subscriptions