unity-api-bugs team mailing list archive

[Ben Harris <bjh21@xxxxxxxxx>]

Public bug reported:

This is a problem in the unity-scope-home source package, version
6.8.2+14.04.20131029.1-0ubuntu1 from Ubuntu 14.04 LTS.

According to Ubuntu policy, the "clean" rule in debian/rules  "must undo
any effects that the build and binary targets may have had, except that
it should leave alone any output files created in the parent directory
by a run of a binary target."  That target in unity-scope-home does not
do this:

root@chickatrice:/tmp# apt-get source unity-scope-home=6.8.2+14.04.20131029.1-0ubuntu1 >/dev/null 2>&1
root@chickatrice:/tmp# find unity-scope-home-6.8.2+14.04.20131029.1 > files.before
root@chickatrice:/tmp# ( cd unity-scope-home-6.8.2+14.04.20131029.1 && debian/rules build && debian/rules clean ) >/dev/null 2>&1
root@chickatrice:/tmp# find unity-scope-home-6.8.2+14.04.20131029.1 > files.after
root@chickatrice:/tmp# diff files.before files.after | grep '^>'
> unity-scope-home-6.8.2+14.04.20131029.1/tests/unit/feedback.dump
> unity-scope-home-6.8.2+14.04.20131029.1/tests/unit/search.dump
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/books.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/photos.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/more_suggestions.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/applications.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/news.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/info.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/code.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/help.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/calendar.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/recipes.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/files.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/searchin.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/boxes.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/notes.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/weather.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/web.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/reference.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/video.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/music.scope
> unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/graphics.scope

It looks like some of the files generating while building are not
correctly removed while cleaning.  This is a problem if (as I do) you
want to convert the package to use the "3.0 (quilt)" source format.

The attached patch seemed to fix the problem for me, but I now worry
about the *.dump files above, which it doesn't touch.

** Affects: unity-scope-home (Ubuntu)
     Importance: Undecided
         Status: New

** Patch added: "Crude patch that might fix the problem"
   https://bugs.launchpad.net/bugs/1326801/+attachment/4125895/+files/mcs-clean

-- 
You received this bug notification because you are a member of Unity API
bugs, which is subscribed to unity-scope-home in Ubuntu.
https://bugs.launchpad.net/bugs/1326801

Title:
  "debain/rules clean" does not clean adequately

Status in “unity-scope-home” package in Ubuntu:
  New

Bug description:
  This is a problem in the unity-scope-home source package, version
  6.8.2+14.04.20131029.1-0ubuntu1 from Ubuntu 14.04 LTS.

  According to Ubuntu policy, the "clean" rule in debian/rules  "must
  undo any effects that the build and binary targets may have had,
  except that it should leave alone any output files created in the
  parent directory by a run of a binary target."  That target in unity-
  scope-home does not do this:

  root@chickatrice:/tmp# apt-get source unity-scope-home=6.8.2+14.04.20131029.1-0ubuntu1 >/dev/null 2>&1
  root@chickatrice:/tmp# find unity-scope-home-6.8.2+14.04.20131029.1 > files.before
  root@chickatrice:/tmp# ( cd unity-scope-home-6.8.2+14.04.20131029.1 && debian/rules build && debian/rules clean ) >/dev/null 2>&1
  root@chickatrice:/tmp# find unity-scope-home-6.8.2+14.04.20131029.1 > files.after
  root@chickatrice:/tmp# diff files.before files.after | grep '^>'
  > unity-scope-home-6.8.2+14.04.20131029.1/tests/unit/feedback.dump
  > unity-scope-home-6.8.2+14.04.20131029.1/tests/unit/search.dump
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/books.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/photos.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/more_suggestions.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/applications.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/news.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/info.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/code.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/help.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/calendar.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/recipes.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/files.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/searchin.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/boxes.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/notes.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/weather.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/web.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/reference.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/video.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/music.scope
  > unity-scope-home-6.8.2+14.04.20131029.1/data/master-scopes/graphics.scope

  It looks like some of the files generating while building are not
  correctly removed while cleaning.  This is a problem if (as I do) you
  want to convert the package to use the "3.0 (quilt)" source format.

  The attached patch seemed to fix the problem for me, but I now worry
  about the *.dump files above, which it doesn't touch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/unity-scope-home/+bug/1326801/+subscriptions