vm team mailing list archive

[Uday S Reddy <u.s.reddy@xxxxxxxxxxxxx>]

Tim Cross writes:

> 
> I have just uploaded fixes for the make-local-hook warnings into my
> compiler-fixes branch. These were pretty straight-forward. XEmacs still
> requires make-local-hook. 

Ok, in that case, we should make a function called vm-make-local-hook
and put it in vm-misc.el.  That way, we limit the silly warnings to
vm-misc.el so that they don't drown out other important warnings.

> Both emacs and xemacs also require the forth
> argument to add-hook to be t to make it local. All relevant add-hook calls
> already had this except one in vm-folder.el i.e.
> 
> (add-hook 'after-save-hook 'vm-unblock-new-mail)
> 
> which I've changed to 
> 
> (add-hook 'after-save-hook 'vm-unblock-new-mail nil t)
> 
> which I think is the correct behavior given the purpose described in the code
> comments. I suspect that for quite a while, it has been local for xemacs, but
> global for GNU emacs. 

Sounds good.

Cheers,
Uday