widelands-dev team mailing list archive

[Hans Joachim Desserud <launchpad@xxxxxxxxxxxx>]

Hans Joachim Desserud has proposed merging lp:~hjd/widelands/cmake-less-update into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~hjd/widelands/cmake-less-update/+merge/246829

Read http://voices.canonical.com/jussi.pakkanen/2013/03/26/a-list-of-common-cmake-antipatterns/

One of the points is that manually running cmake after the initial setup is unnecessary. Tested it locally, and indeed if CMakeLists.txt had been touched, the first step of the buildtool was to re-run cmake.

We might want to look at some of the other points as well. I know we add '-g' explicitly for debug builds, but I'm not sure how to verify this option is still included for debug builds if we don't.
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/cmake-less-update into lp:widelands.

=== modified file 'compile.sh'
--- compile.sh	2014-10-02 17:49:39 +0000
+++ compile.sh	2015-01-17 18:54:01 +0000
@@ -116,7 +116,6 @@
 
 bzr pull
 cd build
-cmake ..
 $buildtool
 rm  ../VERSION || true
 rm  ../widelands || true