widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #03948
Re: [Merge] lp:~widelands-dev/widelands/bug-1451078-fix into lp:widelands
I am not sure if I was speaking clearly.
here, both break (old way) and continue (new way) skip the rest of the test. As a result of this, the soldier is not declared trainable in either case. However, the old way caused the code to skip subsequent arts, which was bad if those trainings were not complete yet.
Old way: Health training complete, evade training not complete: soldier is not declared trainable and might be kicked out, if the status of evade is considered after health.
New way: Soldier stays in.
Anyway, thanks for the quick comments.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1451078-fix/+merge/258118
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1451078-fix into lp:widelands.
References