← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/ai_seafaring_split into lp:widelands

 

Review: Approve

Checked the code and don't find objections. --> Approve

One thing you might consider still is to group declarations in defaultai.h as to current AI segmentation, here: seafaring code.

Another thing you could think about is to, in the longer run, promote segmentation of AI code by seeking to group code references (e.g. declarations) after semantic relation (topic). This would enhance maintainability of the AI code.
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_split/+merge/311544
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_seafaring_split.


References