widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/tribe_basic_info into lp:widelands

To: mp+333974@xxxxxxxxxxxxxxxxxx
From: Notabilis <notabilis27@xxxxxx>
Date: Sat, 16 Dec 2017 11:40:53 -0000
In-reply-to: <151119314389.1398.755089239764060117.launchpad@ackee.canonical.com>
Reply-to: mp+333974@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Actually I am not sure what kind of review makes sense here. Bunnybot does not complain, so I guess everything compiles just fine. I also haven't spotted any errors on a quick glance through.

Breaking up the big libraries is probably a good thing, so as far as I am concerned this can go in. Just out of curiosity: Have you done the comparison of the release build file sizes? Why do you think it should change?

If you have any suggestions what should be done as a review, please say so.
-- 
https://code.launchpad.net/~widelands-dev/widelands/tribe_basic_info/+merge/333974
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/tribe_basic_info into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/tribe_basic_info into lp:widelands
From: GunChleoc, 2017-11-20