widelands-dev team mailing list archive

[Toni Förster <toni.foerster@xxxxxxxxx>]

Toni Förster has proposed merging lp:~widelands-dev/widelands/cmakepolicy into lp:widelands.

Commit message:
set cmake_policy version range to NEW instead of specific policy:

https://cmake.org/cmake/help/v3.12/command/cmake_policy.html

Requested reviews:
  kaputtnik (franku)
Related bugs:
  Bug #1772079 in widelands: "CMake 3.11: warning about FindOpenGL"
  https://bugs.launchpad.net/widelands/+bug/1772079

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/cmakepolicy/+merge/356018

We set the policy CMP0054 to NEW since it was not set. Since I stumbled over bug #1772079 I thought it might be better to set a range instead of every single policy (which is also advised in the cmake manual)

@kaputtnik can you compile this branch on you system. You shouldn't get this warning anymore and Cmake should use the GLVND now.
-- 
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/cmakepolicy.

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2018-09-26 13:41:40 +0000
+++ CMakeLists.txt	2018-10-02 20:48:52 +0000
@@ -1,7 +1,7 @@
 project (widelands)
 
 cmake_minimum_required (VERSION 2.8.7)
-cmake_policy(SET CMP0054 NEW)
+cmake_policy(VERSION 3.11...3.12)
 
 include("${CMAKE_SOURCE_DIR}/cmake/WlFunctions.cmake")