← Back to team overview

yade-dev team mailing list archive

Re: [Yade-commits] r1359 - in trunk: core gui/py lib/import pkg/common/DataClass/PhysicalParameters pkg/common/Engine/DeusExMachina pkg/common/Engine/StandAloneEngine pkg/dem/Engine/EngineUnit pkg/dem/Engine/StandAloneEngine pkg/dem/RenderingEngine/GLDrawElasticContactInteraction

 

> InteractingSphere2InteractingSphere4DistantSpheresContactGeometry
> creates SpheresContacatGeometry; 
Yes.

> contrary to IS2IS4SCG however, it will 
> create SpheresContactGeometry even if penetrationDepth<=0.
Yes. E.q. will IS2IS4SCG create SCG _only_ if penetrationDepth>0?

> > InteractionDetectionFactor should be removed
> > from SpheresContactGeometry.
No, it's wrong.

> > >if (penetrationDepth>0 || c->isReal)
> > should be replaced by
> > > if (penetrationDepth>0)
Why is it wrong?
 
> [ I eventually want to replace IS2IS4DSCG by IS2IS4SCG with some flag
> that will permit distant interactions. There is no reason for such code
> duplication ]
> >
Yes, IS2IS4SCG::go() and IS2IS4DSCG:go() are now _completely_ identical, 
except that I deactivated the condition (...| | c->isReal) in the first in 
accordance with 
>__contrary to IS2IS4SCG however__, it will
> create SpheresContactGeometry even if penetrationDepth<=0.

So, if we use a special flag for distant case, 
the general condition shall be as follows:

> if ( penetrationDepth>0 || (isDistant && c->isReal) )

Is't it?


> isReal is not clear at all and I had to read sources (at all the places
> where it is used) to get to know what it means. isReal for distant
> contact is false, but the contact is not "unreal" nonetheless. 
No... for distant contact it will be true...in accordance with the same condition:

>if (penetrationDepth>0 || c->isReal)

that implies that if isReal was once set, it is not unset over all interaction.

> >
> Why not call it isStale then or something similar?
I assumed the arbitrary use, but only within Engine, as a local variable related to the interaction.
It seems to me that a non-special flag should be...

-- 
Best regards, Sergei D.
_______________________________________________
yade-dev mailing list
yade-dev@xxxxxxxxxxxxxxxx
https://lists.berlios.de/mailman/listinfo/yade-dev



Follow ups

References